-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: llvm: Simplify plain icon #2264
base: develop
Are you sure you want to change the base?
Conversation
5573a32
to
b7eb814
Compare
[why] While the plain icon is plainer than the original icon, it is still quite complex with very thin strokes. [how] Just take the outermost outlines of the plain icon and crate a solid icon from it. Then hand-remove 'dent' in the tail. Signed-off-by: Fini Jastrow <[email protected]>
b7eb814
to
526781b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm, I don't agree with this one. While I agree that the icon could benefit from some simplification I think going all black is too much simplification, making it less recognizable... but let's see what the other maintainers think too :)
Edit:
Good that you fixed the artifact though. That should probably be fixed in the original icon too.
Some context: The original icon is made by converting a png to svg with inkscape. The process is not ideal so there are a few artifacts. I think it could be improved upon now though, since I know there are better png to svg converters out there now than when we made this icon :)
😆 As I said, controversial (see image below). For me, as "in a font" the current plain one is just too intricate. Have a look at it sized down: But that is just for ME and font usage, which might or might not be important for you. |
@Finii |
Sidenote: The old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work 👍
[why]
While the plain icon is plainer than the original icon, it is still quite complex with very thin strokes.
[how]
Just take the outermost outlines of the plain icon and crate a solid icon from it.
Note
This can be controversial.
For me the plain icon is not really plain, it has lots and lots of detail and consists of 2600 nodes:
The simple plain icon proposed here drops all the details and uses just the outline (260 nodes)
If one needs an icon with all the glory details the
-original
should be a good fit, the plain should be a simple(r) version, I believe. But anyhow, this is very opinionated and I do not want to mess with your ideas here. For a small text icon the current plain icon is far too complex and all the small detail hairlines can not be seen anyhow.Double check these details before you open a PR
Features
This PR closes NONE
Notes
@Snailedlt as per ryanoasis/nerd-fonts#1691 (comment)