Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lastModified Filter #444

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Jdubrick
Copy link
Contributor

@Jdubrick Jdubrick commented Jul 9, 2024

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?
This PR aims to fix the issue described in the linked issue below regarding stacks showing the default Go time.Time value. The stack and version vars in the generation script were flipped, resulting in the parsing from index/generator to not be able to find the resulting stacks and issuing the default date as a result.

Which issue(s) this PR fixes:

Link to github issue(s)
fixes devfile/api#1610

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Run bash .ci/build.sh and launch the registry and then hit /v2index to see lastModified dates are not the default anymore

Signed-off-by: Jordan Dubrick <[email protected]>
@Jdubrick Jdubrick requested a review from a team as a code owner July 9, 2024 19:16
@openshift-ci openshift-ci bot added the approved label Jul 9, 2024
Copy link
Member

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jul 9, 2024
Copy link

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick Jdubrick merged commit d1e810c into devfile:main Jul 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community Registry Showing Default Date for lastModified
2 participants