Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
This PR aims to fix the issue described in the linked issue below regarding stacks showing the default Go
time.Time
value. Thestack
andversion
vars in the generation script were flipped, resulting in the parsing fromindex/generator
to not be able to find the resulting stacks and issuing the default date as a result.Which issue(s) this PR fixes:
Link to github issue(s)
fixes devfile/api#1610
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
Run
bash .ci/build.sh
and launch the registry and then hit/v2index
to seelastModified
dates are not the default anymore