Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated cert-manager version v1.11.0---> v1.15.1 #94

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Updated cert-manager version v1.11.0---> v1.15.1 #94

merged 1 commit into from
Sep 4, 2024

Conversation

Horiodino
Copy link
Contributor

Please specify the area for this PR

What does does this PR do / why we need it:
cert-manager version v1.11.0---> v1.13.1 (latest version)

Which issue(s) this PR fixes:
Fixes # devfile/api#1320

PR acceptance criteria:

  • [✅ ] Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

  • Does the registry operator documentation need to be updated with your changes?

Testing changes

kubectl get pods -n cert-manager
NAME                                       READY   STATUS    RESTARTS   AGE
cert-manager-67f7b4f67d-jc9dx              1/1     Running   0          2m1s
cert-manager-cainjector-564b978556-kdsnw   1/1     Running   0          2m1s
cert-manager-webhook-7d54ddf58b-ldntk      1/1     Running   0          2m1s

Running Unit Tests

Running Integration Tests

Special notes to the reviewer:

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 10, 2024

Hi @Horiodino. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Jdubrick
Jdubrick reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Jdubrick
Jdubrick reviewed Aug 12, 2024
View reviewed changes
Makefile Outdated
@@ -17,7 +17,7 @@
VERSION ?= `cat $(PWD)/VERSION`
# Default bundle image tag
BUNDLE_IMG ?= quay.io/devfile/registry-operator-bundle:v$(VERSION)
CERT_MANAGER_VERSION ?= v1.11.0
CERT_MANAGER_VERSION ?= v1.13.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we finding v1.13.1 as the latest? I am looking here https://cert-manager.io/docs/releases/ and see 1.15 as the latest with 1.12 as LTS.

Do we want the latest or something with LTS? @michael-valdron @thepetk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jdubrick I think is a fair point. I'd suggest the latest version that doesn't introduce breaking changes affecting our operateor. Looking at the same link you've shared I see that the suggested version 1.13.1 is no longer supported. As a result, if possible I'd suggest going for >1.14 version as they are supported.

thepetk
thepetk reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replied on @Jdubrick comment

Makefile Outdated
@@ -17,7 +17,7 @@
VERSION ?= `cat $(PWD)/VERSION`
# Default bundle image tag
BUNDLE_IMG ?= quay.io/devfile/registry-operator-bundle:v$(VERSION)
CERT_MANAGER_VERSION ?= v1.11.0
CERT_MANAGER_VERSION ?= v1.13.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jdubrick I think is a fair point. I'd suggest the latest version that doesn't introduce breaking changes affecting our operateor. Looking at the same link you've shared I see that the suggested version 1.13.1 is no longer supported. As a result, if possible I'd suggest going for >1.14 version as they are supported.

@Horiodino
Copy link
Contributor Author

these days i always get google ai based search results that's why i use 1.13 , thanks for the pointing it out

@Horiodino
Copy link
Contributor Author 

make install-cert
kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.15.1/cert-manager.yaml
namespace/cert-manager created
customresourcedefinition.apiextensions.k8s.io/certificaterequests.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/certificates.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/challenges.acme.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/clusterissuers.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/issuers.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/orders.acme.cert-manager.io created

kubectl get pods -n cert-manager
NAME                                      READY   STATUS    RESTARTS   AGE
cert-manager-cainjector-9d956987c-fwpkc   1/1     Running   0          59s
cert-manager-fdd97855b-zk8ff              1/1     Running   0          59s
cert-manager-webhook-9f799c7d7-wql9s      1/1     Running   0          59s

@Jdubrick
Copy link
Contributor

/retest

michael-valdron
michael-valdron requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update this in the documentation as well:

registry-operator/README.md

Line 82 in eb1219b

| `CERT_MANAGER_VERSION` | Version of `cert-manager` installed using `make install-cert` | `v1.11.0` |

@Horiodino Horiodino force-pushed the Update-registry-operator-cert-manager branch from 918de7c to 7050d2e Compare August 26, 2024 16:15
thepetk
thepetk approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@thepetk thepetk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm after all checks are passing

@Horiodino Horiodino changed the title Updated cert-manager version v1.11.0---> v1.13.1 Updated cert-manager version v1.11.0---> v1.15.1 Aug 27, 2024
Jdubrick
Jdubrick approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

michael-valdron
michael-valdron approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Horiodino, Jdubrick, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit c318134 into devfile:main Sep 4, 2024
9 checks passed
@michael-valdron michael-valdron mentioned this pull request Sep 22, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jdubrick Jdubrick Jdubrick approved these changes

@michael-valdron michael-valdron michael-valdron approved these changes

@thepetk thepetk thepetk approved these changes

@johnmcollier johnmcollier Awaiting requested review from johnmcollier

Assignees

@thepetk thepetk

@michael-valdron michael-valdron

@Jdubrick Jdubrick

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Horiodino @Jdubrick @thepetk @michael-valdron