Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registry viewer host alias resolution #51

Merged
merged 6 commits into from
Sep 22, 2023

Address review comments

20eeb41
Select commit
Loading
Failed to load commit list.
Merged

Fix registry viewer host alias resolution #51

Address review comments
20eeb41
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 22, 2023 in 0s

0.00% of diff hit (target 22.72%)

View this Pull Request on Codecov

0.00% of diff hit (target 22.72%)

Annotations

Check warning on line 183 in controllers/devfileregistry_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/devfileregistry_controller.go#L183

Added line #L183 was not covered by tests

Check warning on line 98 in controllers/update.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/update.go#L91-L98

Added lines #L91 - L98 were not covered by tests

Check warning on line 106 in controllers/update.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/update.go#L101-L106

Added lines #L101 - L106 were not covered by tests