Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update owners file #48

Merged
merged 2 commits into from
Sep 15, 2023
Merged

update owners file #48

merged 2 commits into from
Sep 15, 2023

Conversation

yangcao77
Copy link
Contributor

Please specify the area for this PR

What does does this PR do / why we need it:
This PR updates the owners file

Which issue(s) this PR fixes:

Fixes #?

PR acceptance criteria:

  • Change Log
  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

  • Does the registry operator documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

Signed-off-by: Stephanie <[email protected]>
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.30% 🎉

Comparison is base (d8f2e3f) 22.11% compared to head (1d63fc0) 22.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   22.11%   22.41%   +0.30%     
==========================================
  Files          23       23              
  Lines        1307     1307              
==========================================
+ Hits          289      293       +4     
+ Misses       1002      998       -4     
  Partials       16       16              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thepetk
Copy link
Contributor

thepetk commented Sep 13, 2023

/lgtm

I've removed the approval as the list of owners is still under consideration

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed for all others repos of devfile organization we have:

- elsony
- michael-valdron
- thepetk
- feloy
- rm3l

Signed-off-by: Stephanie <[email protected]>
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thepetk, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangcao77 yangcao77 merged commit 46fe9e0 into devfile:main Sep 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants