Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security.md #1627

Merged
merged 7 commits into from
Sep 3, 2024
Merged

Add security.md #1627

merged 7 commits into from
Sep 3, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Aug 22, 2024

Description of Changes

This PR adds a security policy with vulnerability reporting instructions.

Related Issue(s)

Fixes #1629

Acceptance Criteria

Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.

New testing and documentation issues can be opened under devfile/api/issues.

You can check the respective criteria below if either of the following is true:

  • There is a separate tracking issue opened and that issue is linked in this PR.
  • Testing/documentation updates are contained within this PR.

If criteria is left unchecked please provide an explanation why.

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

@thepetk thepetk requested review from AObuchow, dkwon17 and a team as code owners August 22, 2024 10:56
SECURITY.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.75%. Comparing base (b710084) to head (712a395).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1627   +/-   ##
=======================================
  Coverage   35.75%   35.75%           
=======================================
  Files          52       52           
  Lines        6696     6696           
=======================================
  Hits         2394     2394           
  Misses       4158     4158           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, you don't need to incorporate these changes however lgtm

SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Sep 3, 2024
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggested change to the Reporting process section, other than that changes lgtm.

SECURITY.md Outdated Show resolved Hide resolved
thepetk and others added 7 commits September 3, 2024 17:04
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
@thepetk
Copy link
Contributor Author

thepetk commented Sep 3, 2024

Just a suggested change to the Reporting process section, other than that changes lgtm.

@michael-valdron I've updated the content

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 3, 2024
Copy link

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron, thepetk, yangcao77

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 7afd63f into devfile:main Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement security policy for devfile/api
4 participants