-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecated github actions to latest version #1231
Conversation
Signed-off-by: thepetk <[email protected]>
Update deprecated github actions
Signed-off-by: thepetk <[email protected]>
Remove jsonschema dep from validate samples
I've included a fix to the More detailed the error trace from the previous state of this check can be found here https://github.com/devfile/api/actions/runs/5962813005/job/16271495000 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1231 +/- ##
=======================================
Coverage 35.79% 35.79%
=======================================
Files 52 52
Lines 6679 6679
=======================================
Hits 2391 2391
Misses 4144 4144
Partials 144 144 ☔ View full report in Codecov by Sentry. |
Looks like the "latest" release of jsonschema-cli was from a few years ago, so it's a good approach to not use it anymore since it's no longer maintained. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, kim-tsao, thepetk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* 2.2.0 release cut Signed-off-by: Stephanie <[email protected]> * enable gosec (#969) * enable gosec Signed-off-by: Kim Tsao <[email protected]> * Fix G601 errors Signed-off-by: Kim Tsao <[email protected]> * Fix warnings Signed-off-by: Kim Tsao <[email protected]> * Add newline Signed-off-by: Kim Tsao <[email protected]> Signed-off-by: Kim Tsao <[email protected]> * Update the devfile spec to 2.2.1 alpha (#980) Signed-off-by: Paul Schultz <[email protected]> * Bump kubernetes-client/gen revision to fix git dubious ownership error (#1045) * bump kubernetes-client/gen revision to fix git dubious ownership error Signed-off-by: Michael Valdron <[email protected]> * whitespace changes. Signed-off-by: Michael Valdron <[email protected]> * set openapi generator ref to version which supports typescript generation. Signed-off-by: Michael Valdron <[email protected]> --------- Signed-off-by: Michael Valdron <[email protected]> * Fix Dependabot issues (#1047) * fix dependabot issues, requires a bump in k8s versions Signed-off-by: Kim Tsao <[email protected]> * re-generated devworkspace files Signed-off-by: Kim Tsao <[email protected]> * Vendor updates Signed-off-by: Kim Tsao <[email protected]> --------- Signed-off-by: Kim Tsao <[email protected]> * fix gosec v2.14.0 (#1034) Signed-off-by: Michael Valdron <[email protected]> * Update python runtime version for `release-typescript-models` job (#1051) * bump python runtime version for 'release-typescript-models' job. Signed-off-by: Michael Valdron <[email protected]> * bump setup-python action to v4 for 'release-typescript-models' job. Signed-off-by: Michael Valdron <[email protected]> --------- Signed-off-by: Michael Valdron <[email protected]> * Add workflow for managing stale issues & PRs (#1055) Adds a GitHub workflow for managing stale & rotten issues and PRs. Issues & PRs are marked stale after 90 days of inactivity. After 60 further days, they are marked as rotten and closed. * Clarify hotReloadCapable field (#1091) * Clarify hotReloadCapable field Signed-off-by: Philippe Martin <[email protected]> * Auto-generated Signed-off-by: Philippe Martin <[email protected]> * Specify isDefault Signed-off-by: Philippe Martin <[email protected]> * Clarify description Signed-off-by: Philippe Martin <[email protected]> --------- Signed-off-by: Philippe Martin <[email protected]> * update kubernetes/openshift endpoint validation (#1098) * update endpoint validation Signed-off-by: Stephanie <[email protected]> * update unit test Signed-off-by: Stephanie <[email protected]> * update the test error check to be more clear Signed-off-by: Stephanie <[email protected]> * add unit test for two kube components Signed-off-by: Stephanie <[email protected]> --------- Signed-off-by: Stephanie <[email protected]> * Update release doc (#1110) Signed-off-by: Kim Tsao <[email protected]> * Update directly executed scripts inside workflows (#1107) * Update directly executed scripts on workflows Signed-off-by: thepetk <[email protected]> * Update directly executed scripts on bash scripts Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]> * Add area alizer label to all issue templates (#1149) Signed-off-by: thepetk <[email protected]> * Update deprecated github actions to latest version (#1231) * Update deprecated github actions Signed-off-by: thepetk <[email protected]> * Remove jsonschema dep from validate samples Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]> * Add license header file and script (#1256) * add license header file Signed-off-by: Michael Valdron <[email protected]> * addlicense script Signed-off-by: Michael Valdron <[email protected]> * update README with instructions on adding license headers Signed-off-by: Michael Valdron <[email protected]> * update license headers under source files Signed-off-by: Michael Valdron <[email protected]> * remove license header from generated source Signed-off-by: Michael Valdron <[email protected]> * add_license.sh ignores zz_generated.* source files Signed-off-by: Michael Valdron <[email protected]> * check license headers script added Signed-off-by: Michael Valdron <[email protected]> * check license headers script added to CI workflow Signed-off-by: Michael Valdron <[email protected]> --------- Signed-off-by: Michael Valdron <[email protected]> * add signoff Signed-off-by: Stephanie <[email protected]> --------- Signed-off-by: Stephanie <[email protected]> Signed-off-by: Kim Tsao <[email protected]> Signed-off-by: Paul Schultz <[email protected]> Signed-off-by: Michael Valdron <[email protected]> Signed-off-by: Philippe Martin <[email protected]> Signed-off-by: thepetk <[email protected]> Co-authored-by: Kim Tsao <[email protected]> Co-authored-by: Paul Schultz <[email protected]> Co-authored-by: Michael Valdron <[email protected]> Co-authored-by: Michael Valdron <[email protected]> Co-authored-by: John Collier <[email protected]> Co-authored-by: Philippe Martin <[email protected]> Co-authored-by: Theofanis Petkos <[email protected]>
What does this PR do?
This PR updates all deprecated github actions using NodeJS 12 in order to use NodeJS 16. The list of actions updated are:
actions/checkout@v2
>actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
actions/setup-go@v2
>actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
codecov/[email protected]
>codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
Which issue(s) does this PR fix
Fixes #1224
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer
I've tried to test the new versions of actions in my fork. Some of them might fail as we are inside a forked repo but the github actions run without an issue: