Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example folder #366

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

horacioh
Copy link

add an example folder to share project configurations using microbundle.

the example I added is using:

  • React
  • Typescript
  • Storybook
  • Styled systems
  • styled components

hopefully this will be helpful for new devs :)

@maraisr
Copy link
Contributor

maraisr commented Apr 2, 2019

Thanks for the PR, but what problem are you trying to solve here? Storybook is still using webpack to build it's things. So really all you're showing here is that microbundle can be used alongside Storybook. What would be cool, would be if Storybook was to consume the microbundle dev build. But even then this is a bundler...

Maybe this can be an example you could maintain in your own personal land, and we can ask @developit if we could reference it in the readme or something.

All in all, the maintainers here wouldn't want to now maintain examples, and test that all the examples still work etc...

@horacioh
Copy link
Author

horacioh commented Apr 2, 2019

thanks for the response @maraisr !

my first approach was what you said: #365. I think this is cleaner for the proyect too.

I'm happy to reopen/update/delete this PRs. I found examples really useful for newcomers to the project, and check how the setup (specially the setup) is done is really helpful.

Hope we can give the community a way to publish more examples as this one!

Let me know what you think 👍

@developit
Copy link
Owner

I'd love a microbundle-examples repo.

@devinrhode2
Copy link

Storybook is still using webpack to build it's things. So really all you're showing here is that microbundle can be used alongside Storybook. What would be cool, would be if Storybook was to consume the microbundle dev build.

Storybook now has a vite builder, which can replace webpack. Vite is mostly based on Rollup, with some esbuild sprinkled in where possible.

I wonder if Microbundle could be implemented on top of vite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants