Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool for generating image release changes #868

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

eljog
Copy link
Member

@eljog eljog commented Dec 1, 2023

https://github.com/devcontainers/internal/issues/68

This pull request introduces a new script, prepare-release.sh, in the build directory. The script is designed to automate the process of preparing a release of the dev containers. It includes functionality to bump the version of the manifest.json file and run the devcontainer upgrade command. The script operates on either all images (useful for monthly release) or only those that have been modified since the last release commit (useful for ad-hoc release)

The release PR #869 is created using this tool

  • build/prepare-release.sh: A new shell script that prepares a release of the dev containers. The script includes functions to get modified images, get all images, bump the version of the manifest.json file, and release an image. It also includes two types of releases: adhoc and monthly. The adhoc release operates on images modified since the last release commit, while the monthly release operates on all images. The script accepts a commit hash as input. If no commit hash is provided, it defaults to an monthly release.

Example adhoc release:
./build/prepare-release.sh 1c6f558dc86aafd7749074ec44e238f331303517
Example monthly release:
./build/prepare-release.sh

Note: It only bumps patch version. If you need to bump minor/major versions, that needs to be done manually.

image

@eljog eljog requested a review from a team as a code owner December 1, 2023 21:32
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thanks for this enhancement 🎉

Looks great, left some minor comments.

build/prepare-release.sh Outdated Show resolved Hide resolved
build/prepare-release.sh Show resolved Hide resolved
Copy link
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re approving

@eljog eljog merged commit 53b9984 into main Dec 7, 2023
19 checks passed
@eljog eljog deleted the eljog/tool-for-generating-image-release-changes branch December 7, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants