[Cpp] - Only exit vcpkg install early on Buster ARM64 #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarebyte
force-pushed
the
tarebyte/remove-arm64-conditional
branch
from
2af0a34
to
0fbf2ce
Compare
tarebyte
changed the title
|
@microsoft-github-policy-service agree |
tarebyte
changed the title
tarebyte
force-pushed
the
tarebyte/remove-arm64-conditional
branch
from
0fbf2ce
to
292088f
Compare
|
Hey @tarebyte -- are you still working on this? :) I am currently running into this regression as well, where I am missing As far as I understand the modifications concerning |
|
I wasn't working on it 😄 But I removed the |
samruddhikhandale
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where all ARM64 OS builds are blocked even if they ship with CMake > 3.15 This appears to be a regression from #588.
Looking through the packages I think that the only OS that doesn't ship with the right CMake is Debian Buster.
This pull request updates the conditional to add back in the denylist so that other new operating systems can install
vcpkg.I've also updated the script logic so thatVCPKG_FORCE_SYSTEM_BINARIESis set when usingarm64. If there is a better way to do this please let me know!Thanks!