Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Python settings #671

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Remove deprecated Python settings #671

merged 2 commits into from
Oct 18, 2023

Conversation

luabud
Copy link
Contributor

@luabud luabud commented Jul 21, 2023

Follow up to devcontainers/features#625

Leaving as a draft for now until we decide what we will do about replacements (devcontainers/features#625 (comment))

@luabud luabud marked this pull request as ready for review October 18, 2023 21:44
@luabud luabud requested a review from a team as a code owner October 18, 2023 21:44
@luabud
Copy link
Contributor Author

luabud commented Oct 18, 2023 •
edited
Loading

Marking as ready for review since the other PR has been merged :)

samruddhikhandale
samruddhikhandale approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, appreciate the clean up! 🧹 ✨

@samruddhikhandale samruddhikhandale merged commit c492728 into devcontainers:main Oct 18, 2023
5 checks passed
@samruddhikhandale samruddhikhandale mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luabud @samruddhikhandale