Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Universal] - reduce size - removed nvidia, triton - Machine Learning Packages #1014

Merged
merged 31 commits into from
May 9, 2024
Merged

[Universal] - reduce size - removed nvidia, triton - Machine Learning Packages #1014

merged 31 commits into from
May 9, 2024

Conversation

gauravsaini04
Copy link
Contributor

@gauravsaini04 gauravsaini04 commented Apr 2, 2024 •
edited
Loading

Dev container name:

  • Universal

Description:

  • Shrink size of the Universal Image

Changelog:

  • Changed install.sh file in local-features of Machine-learning-packages, so that GPU acceleration will be available for those machines only, that have an NVIDIA gpu available, so packages like nvidia & triton & few others will be installed as default, so to avoid downloading and installing of big sized packages such as nvidia & triton for all other machines

Checklist:

  • Checked that applied changes work as expected

@gauravsaini04 gauravsaini04 requested a review from a team as a code owner April 2, 2024 17:16
@samruddhikhandale
Copy link
Member

Seems like tests did not run for this PR, closing and opening it.

samruddhikhandale
samruddhikhandale requested changes Apr 8, 2024
View reviewed changes
src/universal/.devcontainer/OnCreateCommand.sh Outdated Show resolved Hide resolved
src/universal/.devcontainer/OnCreateCommand.sh Outdated Show resolved Hide resolved
src/universal/.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
src/universal/.devcontainer/local-features/machine-learning-packages/install.sh Show resolved Hide resolved
src/universal/.devcontainer/OnCreateCommand.sh Outdated Show resolved Hide resolved
src/universal/.devcontainer/OnCreateCommand.sh Outdated Show resolved Hide resolved
src/universal/.devcontainer/OnCreateCommand.sh Outdated Show resolved Hide resolved
src/universal/.devcontainer/OnCreateCommand.sh Outdated Show resolved Hide resolved
src/universal/.devcontainer/OnCreateCommand.sh Outdated Show resolved Hide resolved
src/universal/.devcontainer/OnCreateCommand.sh Outdated Show resolved Hide resolved
@gauravsaini04 gauravsaini04 marked this pull request as draft April 9, 2024 22:33
@gauravsaini04 gauravsaini04 marked this pull request as ready for review April 16, 2024 10:44
samruddhikhandale
samruddhikhandale approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a wonderful change, so good to see the universal image shrink from 14 GB to 9.8 GB 🎉

@samruddhikhandale samruddhikhandale merged commit cf8f3ec into devcontainers:main May 9, 2024
18 checks passed
@gauravsaini04 gauravsaini04 deleted the universal_reduce_size_mlp_remove_nvidia_triton branch May 10, 2024 02:59
@samruddhikhandale samruddhikhandale mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gauravsaini04 @samruddhikhandale