Fix Coverage calculation #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertdstein
approved these changes
Jul 29, 2024
robertdstein
force-pushed
the
fic-coverage
branch
from
cd33932
to
4a3df81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying the healpix pixels in a disc around the neutrino position, we have to make sure all pixels that fall within the rectangle are selected. That is the case if we take the longest side of the rectangle given by the coordinate uncertainties and devide it by$\sqrt{2}$ not $2$ !
Probably some coverage estimates in the past were a bit too optimistic.