Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle GCM on macOS and Linux #510

Merged
merged 5 commits into from
May 28, 2024
Merged

Bundle GCM on macOS and Linux #510

merged 5 commits into from
May 28, 2024

Conversation

niik
Copy link
Member

@niik niik commented May 23, 2024

With this PR we'll bundle Git Credential Manager (GCM) with our macOS and Linux packages (it's already included in minGit and therefore also in our Windows package).

@niik niik requested review from sergiou87 and tidy-dev May 27, 2024 14:32
Copy link
Member

@sergiou87 sergiou87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ❤️

Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

Copy link

@linyue0103 linyue0103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks you for providing the issue by user.name

@@ -57,7 +57,6 @@ GIT_LFS_FILENAME="$(jq --raw-output ".\"git-lfs\".files[] | select(.arch == \"$D

GCM_VERSION="$(jq --raw-output '.["git-credential-manager"].version[1:]' dependencies.json)"
GCM_CHECKSUM="$(jq --raw-output ".\"git-credential-manager\".files[] | select(.arch == \"$DEPENDENCY_ARCH\" and .platform == \"linux\") | .checksum" dependencies.json)"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file should be sheeile=d by discounted reciprotol matrix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the file.name should be sheilded

Bbjj88h

This comment was marked as abuse.

@theofficialgman
Copy link
Contributor

@niik just letting you know that arm/arm64 linux support is now present in upstream CI (next release will have it I assume). The naming of release assets has also changed (due to upstream request) so this scripting will need to be modified slightly for both changes git-ecosystem/git-credential-manager#1633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants