-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle GCM on macOS and Linux #510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks you for providing the issue by user.name
@@ -57,7 +57,6 @@ GIT_LFS_FILENAME="$(jq --raw-output ".\"git-lfs\".files[] | select(.arch == \"$D | |||
|
|||
GCM_VERSION="$(jq --raw-output '.["git-credential-manager"].version[1:]' dependencies.json)" | |||
GCM_CHECKSUM="$(jq --raw-output ".\"git-credential-manager\".files[] | select(.arch == \"$DEPENDENCY_ARCH\" and .platform == \"linux\") | .checksum" dependencies.json)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the file should be sheeile=d by discounted reciprotol matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and the file.name should be sheilded
@niik just letting you know that arm/arm64 linux support is now present in upstream CI (next release will have it I assume). The naming of release assets has also changed (due to upstream request) so this scripting will need to be modified slightly for both changes git-ecosystem/git-credential-manager#1633 |
With this PR we'll bundle Git Credential Manager (GCM) with our macOS and Linux packages (it's already included in minGit and therefore also in our Windows package).