fix updater confused by blank commit #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there a way to add tests to catch this earlier in the future and/or prevent regressions? |
abdulapopoola
approved these changes
Sep 7, 2023
|
I added a unit test for this case. It would be better to have integration tests around the different options, but it's probably overkill. |
jakecoffman
deleted the
jakecoffman/fix-dependabot-update-github-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging an issue I noticed that
dependabot update github_actions dependabot/smoke-testsdoesn't work. It tries to pull a blank ref which fails.The cause of this is due to the
--commitoption defaulting to""which gets passed into the updater viajob.json. This makes the updater think there's a commit present, but when it goes to use it, it's blank and the update fails.I swapped out the pointer on the type which simplifies a bunch of code, but adding the
omitemptyis what actually fixes the problem.