Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize empty group slices #173

Merged
merged 1 commit into from
Aug 23, 2023
Merged

initialize empty group slices #173

merged 1 commit into from
Aug 23, 2023

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman requested a review from a team as a code owner August 23, 2023 18:58
honeyankit
honeyankit approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@honeyankit honeyankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my understanding, we are trying to avoid job object attributes to be initialized and not nil.

@jakecoffman
Copy link
Member Author

we are trying to avoid job object attributes to be initialized and not nil.

Avoiding undefined or null in the job JSON definition, which would translate to nil in the Ruby.

@jakecoffman jakecoffman merged commit 2113018 into main Aug 23, 2023
40 checks passed
@jakecoffman jakecoffman deleted the jakecoffman/add-group-values branch August 23, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honeyankit honeyankit honeyankit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakecoffman @honeyankit