Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix proxy hostname unresolvable in k8s #166

Merged
merged 2 commits into from
Aug 11, 2023
Merged

fix proxy hostname unresolvable in k8s #166

merged 2 commits into from
Aug 11, 2023

Conversation

jakecoffman
Copy link
Member

probably fixes #159

This implements the same fix @mctofu linked to in github/dependabot-action#136

Also removed rand.Seed because rand is automatically seeded since Go 1.20.

@jakecoffman jakecoffman requested a review from a team as a code owner August 11, 2023 19:23
honeyankit
honeyankit approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@honeyankit honeyankit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! CI build test is failing.

@honeyankit honeyankit self-requested a review August 11, 2023 19:25
@jakecoffman jakecoffman merged commit 35d5056 into main Aug 11, 2023
40 checks passed
@jakecoffman jakecoffman deleted the jakecoffman/refer-to-the-proxy-by-ip branch August 11, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honeyankit honeyankit honeyankit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jenkins Docker/Kubernetes DNS resolution to proxy with random name
2 participants
@jakecoffman @honeyankit