fix: --no-default-features flag was broken (#111)

denoland · Dec 5, 2023 · fee9352 · fee9352
1 parent 2f356fb
commit fee9352
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 2 deletions.
diff --git a/deno.lock b/deno.lock
diff --git a/lib/args.test.ts b/lib/args.test.ts
@@ -0,0 +1,16 @@
+import { assertEquals } from "https://deno.land/[email protected]/assert/mod.ts";
+import { CommonBuild, parseArgs } from "./args.ts";
+
+Deno.test("no default features", () => {
+  const args = parseArgs([
+    "--features",
+    "wasm",
+    "--no-default-features",
+    "--out",
+    "js",
+  ]);
+  assertEquals(
+    (args as CommonBuild).cargoFlags,
+    ["--no-default-features", "--features", "wasm"],
+  );
+});
diff --git a/lib/args.ts b/lib/args.ts
@@ -77,7 +77,7 @@ export function parseArgs(rawArgs: string[]): Command {
   function getCargoFlags() {
     const cargoFlags = [];
 
-    if (flags["default-features"] === false) {
+    if (flags["no-default-features"]) {
       cargoFlags.push("--no-default-features");
     }
     if (flags["features"]) {