feat(csv): infer column names from object arrays for stringify() #6122
+56
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
efekrskl
commented
Oct 16, 2024
Comment on lines
-76
to
-89
| await t.step( | ||
| { | ||
| name: "Invalid data, no columns", | ||
| fn() { | ||
| const data = [{ a: 1 }, { a: 2 }]; | ||
| assertThrows( | ||
| () => stringify(data), | ||
| TypeError, | ||
| "No property accessor function was provided for object", | ||
| ); | ||
| }, | ||
| }, | ||
| ); | ||
| await t.step( |
There was a problem hiding this comment.
Looks like these were duplicates, removed both as they are not relevant anymore
efekrskl
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6122 +/- ##
==========================================
- Coverage 96.57% 96.55% -0.03%
==========================================
Files 535 535
Lines 40583 40600 +17
Branches 6094 6099 +5
==========================================
+ Hits 39195 39203 +8
- Misses 1344 1352 +8
- Partials 44 45 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3857
Allows usages like below by deriving the column names from the first array item