Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell: rewrite fish plugin #930

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jan 9, 2025

Years ago in #671 I did a big refactor to the fish plugin, however I did not understand the code correctly. It removed a feature and has a minor bug (#928).

This pull request rewrites the fish plugin. It is backwards compatible (still binds to Ctrl G, user key binding to the main function _navi_smart_replace keeps working). Current behavior:

  1. Retrieve current command line as query to navi
  2. Check if there's a best match and replace current command line
  3. Open navi with current command line as query, replace current command line if user makes a selection. Previously the plugin only opens navi if command line is empty, i.e. if query doesn't have a best match the key binding will do nothing.

@kidonng kidonng requested a review from denisidoro as a code owner January 9, 2025 06:40
@kidonng kidonng changed the title Rewrite fish plugin shell: rewrite fish plugin Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant