Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ administrateur j'ai davantage d'informations sur le routage à partir d'un champ #11042

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

E-L-T
Copy link
Contributor

@E-L-T E-L-T commented Nov 13, 2024

Correspond à une partie de #10766 (routage à partir d'un champ)

  • Mise à jour de la page Configuration du routage à partir d'un champ (textes et UI)
  • Ajout d'un bandeau d'information
  • Ajout du type des champs "simple routables"
  • Pour les champs de type choix simple, ajout des options en info-bulle
  • Ajout d'une modale une fois le routage configuré

AVANT

Capture d’écran 2024-11-13 à 11 18 05

APRÈS

Capture d’écran 2024-11-13 à 10 49 29

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (4b740f8) to head (bccef87).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11042      +/-   ##
==========================================
- Coverage   84.31%   84.31%   -0.01%     
==========================================
  Files        1171     1171              
  Lines       25833    25839       +6     
  Branches     4875     4877       +2     
==========================================
+ Hits        21782    21785       +3     
- Misses       4051     4054       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@E-L-T E-L-T force-pushed the update-routage-a-partir-d-un-champ branch 5 times, most recently from e595271 to 66602a2 Compare November 13, 2024 12:49
@E-L-T E-L-T marked this pull request as ready for review November 13, 2024 12:50

- each_button do |label, value, hint, **button_options|
- index = 0
- each_button do |label, value, hint, tooltip, **button_options|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

est ce que tu pourrais modifier le composant radio_button_list_component pour rajouter un with_index ~ligne 20, puis de le passer au boutton_options pour t'en servir ici ?

@E-L-T E-L-T force-pushed the update-routage-a-partir-d-un-champ branch 2 times, most recently from 28be486 to b8b6576 Compare November 15, 2024 10:16
@E-L-T E-L-T force-pushed the update-routage-a-partir-d-un-champ branch from b8b6576 to bccef87 Compare November 15, 2024 10:41
@E-L-T
Copy link
Contributor Author

E-L-T commented Nov 15, 2024

@LeSim j'ai mis à jour les wordings suite à des échanges avec Marlène et Lisa.
Ça donne ça :

Capture d’écran 2024-11-15 à 13 59 38

ET

Capture d’écran 2024-11-15 à 14 00 02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants