Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP – correctif: Le champ rna peut rendre deux message de status #11028

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Nov 7, 2024

No description provided.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.75%. Comparing base (00302b8) to head (cdee139).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
.../components/dsfr/input_status_message_component.rb 85.71% 1 Missing ⚠️
app/models/champs/rna_champ.rb 66.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (00302b8) and HEAD (cdee139). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (00302b8) HEAD (cdee139)
16 6
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11028      +/-   ##
==========================================
- Coverage   84.51%   75.75%   -8.76%     
==========================================
  Files        1163     1163              
  Lines       25729    26369     +640     
  Branches     4857     4668     -189     
==========================================
- Hits        21744    19976    -1768     
- Misses       3985     6393    +2408     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfo mfo changed the title correctif: Le champ rna peut rendre deux message de status WIP – correctif: Le champ rna peut rendre deux message de status Nov 7, 2024
@mfo mfo force-pushed the a11y-rnf-rna branch 7 times, most recently from e496ba7 to a0864fb Compare November 12, 2024 13:24
… about rna found or not] within the input_status_message_component for screen reader verbalisation
…t do not import error when champ is blank because we do not show empty errors on the fly

feat(rna): extract error i18n within dedicated file
feat(champ_rna): do not use custom i18n empty message when there is already existing blank error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant