Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP – Us/navigation next/prev accros dossiers #10898

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Oct 7, 2024

depends_on: #10877

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 79.61165% with 21 lines in your changes missing coverage. Please review.

Project coverage is 73.44%. Comparing base (4b740f8) to head (018c0a2).

Files with missing lines Patch % Lines
app/models/cache/show_procedure_last_state.rb 85.93% 9 Missing ⚠️
...pp/controllers/instructeurs/dossiers_controller.rb 27.27% 8 Missing ⚠️
.../controllers/instructeurs/procedures_controller.rb 63.63% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4b740f8) and HEAD (018c0a2). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (4b740f8) HEAD (018c0a2)
16 5
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10898       +/-   ##
===========================================
- Coverage   84.31%   73.44%   -10.88%     
===========================================
  Files        1171     1174        +3     
  Lines       25833    26581      +748     
  Branches     4875     4668      -207     
===========================================
- Hits        21782    19523     -2259     
- Misses       4051     7058     +3007     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfo mfo force-pushed the US/navigation-accros-dossiers branch from 2b29962 to cfa245e Compare October 7, 2024 21:34
…ossiers while caching last viewed tab/and for smoother back and forth navigations between instructeur_procedure_show and instructeur_procedure_dossier_show
… better for identification, get ready for some support complaints
…d_paginated_ids. indeed, users can only go on one of dossiers presented in the current list
…list navigation handling out of bound indexes and invalid index
…nt dossier reaches cached paginated id close to 5 items from last bound
…n current dossier reaches cached paginated id close to 5 items from last bound
@mfo mfo force-pushed the US/navigation-accros-dossiers branch from cfa245e to 018c0a2 Compare November 15, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant