Miscellaneous blob file deduplication improvements/fixes #6471
+31
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hocuri
force-pushed
the
hoc/deduplicate-even-more
branch
from
df0f016 to
863e3a2
Compare
Hocuri
changed the title
Hocuri
force-pushed
the
hoc/deduplicate-even-more
branch
from
863e3a2 to
5d5d147
Compare
Hocuri
changed the title
Hocuri
changed the title
Hocuri
changed the title
Hocuri
changed the title
These were the last places in the `deltachat` crate where files were stored without deduplication. The CFFI python bindings are the last thing that's still missing.
There was a bug that file extensions were removed when recoding an avatar. The problem was that `recode_avatar` used `name` to check for the extension, but some functions passed an empty string. There even were two tests from before the decision to keep the extensions that tested for the faulty behavior.
Hocuri
force-pushed
the
hoc/deduplicate-even-more
branch
from
bb402ae to
8bbd3c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
I'll rebase-merge this PR.
Part of #6265