Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate delta-kernel-rust-sharing-wrapper Python package build is broken #636

Conversation

lwfitzgerald
Copy link

@lwfitzgerald lwfitzgerald commented Jan 21, 2025

The delta-kernel-rust-sharing-wrapper Python package build is failing with:

$ maturin develop

...

   Compiling delta-kernel-rust-sharing-wrapper v0.2.1 (/users/is/lwfitzgerald/delta-sharing-py-v1.3.1/python/delta-kernel-rust-sharing-wrapper)
error[E0277]: the trait bound `arrow::array::RecordBatch: From<Box<ArrowEngineData>>` is not satisfied
   --> src/lib.rs:109:14
    |
109 |             .into();
    |              ^^^^ the trait `From<Box<ArrowEngineData>>` is not implemented for `arrow::array::RecordBatch`
    |
    = help: the following other types implement trait `From<T>`:
              `arrow::array::RecordBatch` implements `From<&StructArray>`
              `arrow::array::RecordBatch` implements `From<StructArray>`
    = note: required for `Box<ArrowEngineData>` to implement `Into<arrow::array::RecordBatch>`

error[E0277]: the trait bound `arrow::datatypes::Schema: TryFrom<&StructType>` is not satisfied
  --> src/lib.rs:93:33
   |
93 |     Ok(Arc::new(schema.as_ref().try_into().map_err(|e| {
   |                                 ^^^^^^^^ the trait `From<&StructType>` is not implemented for `arrow::datatypes::Schema`
   |
   = note: required for `&StructType` to implement `Into<arrow::datatypes::Schema>`
   = note: required for `arrow::datatypes::Schema` to implement `TryFrom<&StructType>`
   = note: required for `&StructType` to implement `TryInto<arrow::datatypes::Schema>`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `delta-kernel-rust-sharing-wrapper` (lib) due to 2 previous errors
💥 maturin failed
  Caused by: Failed to build a native library through cargo
  Caused by: Cargo build finished with "exit status: 101": `env -u CARGO PYO3_ENVIRONMENT_SIGNATURE="cpython-3.8-64bit" PYO3_PYTHON="/turbo/lwfitzgerald/pyenvs/tmpzt6ks8zp/bin/python" PYTHON_SYS_EXECUTABLE="/turbo/lwfitzgerald/pyenvs/tmpzt6ks8zp/bin/python" "cargo" "rustc" "--features" "pyo3/extension-module" "--message-format" "json-render-diagnostics" "--manifest-path" "/users/is/lwfitzgerald/delta-sharing-py-v1.3.1/python/delta-kernel-rust-sharing-wrapper/Cargo.toml" "--lib"`

Environment:

$ python --version
Python 3.8.12

$ maturin -V
maturin 1.8.1

$ rustc -V
rustc 1.84.0 (9fc6b4312 2025-01-07)

@lwfitzgerald
Copy link
Author

Closing as this appears to have been fixed by #634.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant