Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Type Changes for Virtual IP #82

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

Krunal-Thakkar
Copy link
Collaborator

@Krunal-Thakkar Krunal-Thakkar commented Aug 28, 2023

Description

Cluster Type Changes for Virtual IP support

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
910

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

image

@Krunal-Thakkar Krunal-Thakkar merged commit 30aab69 into main Aug 28, 2023
1 check failed
@shanmydell shanmydell deleted the cluster_deployment branch October 16, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants