Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usr/sreekb/powerflex sdc optional #131

Merged
merged 14 commits into from
Sep 23, 2024

Conversation

bharathsreekanth
Copy link
Collaborator

@bharathsreekanth bharathsreekanth commented Sep 20, 2024

Description

Changes to support ping of a NAS server on Powerflex.

GitHub Issue #
dell/csm#663

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Tests
  • Import the goscaleio into driver dependency and test manually all the array calls

nfs_test.go Outdated Show resolved Hide resolved
@bharathsreekanth bharathsreekanth merged commit f072f0c into main Sep 23, 2024
4 checks passed
@bharathsreekanth bharathsreekanth deleted the usr/sreekb/powerflex-sdc-optional branch September 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants