Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SDT deployment via CSV #130

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Support SDT deployment via CSV #130

merged 1 commit into from
Sep 18, 2024

Conversation

baoy1
Copy link
Contributor

@baoy1 baoy1 commented Sep 12, 2024 •
edited
Loading

Description

  • Add SDT related structs
  • Add RenewInstallationCookie to get valid cookie that can be used during cluster deployment
  • Replace cookie dir /home to user's home directory to avoid the case that user doesn't have write permission to /home or OS is Windows

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UT TestRenewInstallationCookie
    image

@baoy1 baoy1 requested a review from RayLiu7 September 14, 2024 02:55
shenda1
shenda1 reviewed Sep 16, 2024
View reviewed changes
deploy.go Outdated
@@ -978,6 +987,47 @@ func (gc *GatewayClient) MoveToIdlePhase() (*types.GatewayResponse, error) {
return &gatewayResponse, nil
}

// RenewInstallationCookie is used to renew the installation cookie, i.e. LEGACYGWCOOKIE.
// Using the same LEGACYGWCOOKIE ensures that the REST requets are sent to the same GW pod.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed.

@baoy1
Support SDT deployment via CSV
1487736 
- Add SDT related structs
- Add RenewInstallationCookie to get valid cookie that can be used
  during cluster deployment
- Replace cookie dir `/home` to user's home directory to avoid the case
  that user doesn't have write permission to `/home` or OS is Windows
@baoy1 baoy1 merged commit cb49451 into main Sep 18, 2024
4 checks passed
@baoy1 baoy1 deleted the sdt-csv-deploy branch October 12, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krunal-Thakkar Krunal-Thakkar Krunal-Thakkar approved these changes

@shenda1 shenda1 shenda1 approved these changes

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@Krishnan-Priyanshu Krishnan-Priyanshu Awaiting requested review from Krishnan-Priyanshu

@AnikaAgiwal2711 AnikaAgiwal2711 Awaiting requested review from AnikaAgiwal2711

@rounak-adhikary rounak-adhikary Awaiting requested review from rounak-adhikary

@gokul-srivathsan gokul-srivathsan Awaiting requested review from gokul-srivathsan

@doriac11 doriac11 Awaiting requested review from doriac11

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@ashleyvjoy ashleyvjoy Awaiting requested review from ashleyvjoy ashleyvjoy is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@khareRajshree khareRajshree Awaiting requested review from khareRajshree khareRajshree is a code owner

@KshitijaKakde KshitijaKakde Awaiting requested review from KshitijaKakde KshitijaKakde is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rishabhatdell rishabhatdell Awaiting requested review from rishabhatdell rishabhatdell is a code owner

@sakshi-garg1 sakshi-garg1 Awaiting requested review from sakshi-garg1 sakshi-garg1 is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4 suryagupta4 is a code owner

@RayLiu7 RayLiu7 Awaiting requested review from RayLiu7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baoy1 @shenda1 @Krunal-Thakkar