NVMe host name could be null

dell · Oct 25, 2024 · 756f3e4 · 756f3e4
1 parent da6863d
commit 756f3e4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/nvme_host.go b/nvme_host.go
@@ -59,7 +59,7 @@ func (s *System) GetAllNvmeHosts() ([]types.NvmeHost, error) {
 }
 
 // GetNvmeHostByID returns an NVMe host searched by id
-func (s *System) GetNvmeHostByID(id string) (*NvmeHost, error) {
+func (s *System) GetNvmeHostByID(id string) (*types.NvmeHost, error) {
 	defer TimeSpent("GetNvmeHostByID", time.Now())
 
 	path := fmt.Sprintf("api/instances/Sdc::%v", id)
@@ -71,7 +71,7 @@ func (s *System) GetNvmeHostByID(id string) (*NvmeHost, error) {
 		return nil, err
 	}
 
-	return NewNvmeHost(s.client, &nvmeHost), nil
+	return &nvmeHost, nil
 }
 
 // CreateNvmeHost creates a new NVMe host

diff --git a/nvme_host_test.go b/nvme_host_test.go
@@ -148,7 +148,7 @@ func Test_GetAllNvmeHosts(t *testing.T) {
 }
 
 func Test_GetNvmeHostByID(t *testing.T) {
-	type checkFn func(*testing.T, *NvmeHost, error)
+	type checkFn func(*testing.T, *types.NvmeHost, error)
 	check := func(fns ...checkFn) []checkFn { return fns }
 
 	responseJSON := `{
@@ -201,19 +201,19 @@ func Test_GetNvmeHostByID(t *testing.T) {
     ]
 }`
 
-	hasNoError := func(t *testing.T, _ *NvmeHost, err error) {
+	hasNoError := func(t *testing.T, _ *types.NvmeHost, err error) {
 		if err != nil {
 			t.Fatalf("expected no error")
 		}
 	}
 
-	checkName := func(name string) func(t *testing.T, host *NvmeHost, err error) {
-		return func(t *testing.T, host *NvmeHost, _ error) {
-			assert.Equal(t, host.NvmeHost.Name, name)
+	checkName := func(name string) func(t *testing.T, host *types.NvmeHost, err error) {
+		return func(t *testing.T, host *types.NvmeHost, _ error) {
+			assert.Equal(t, host.Name, name)
 		}
 	}
 
-	hasError := func(t *testing.T, _ *NvmeHost, err error) {
+	hasError := func(t *testing.T, _ *types.NvmeHost, err error) {
 		if err == nil {
 			t.Fatalf("expected error")
 		}

diff --git a/types/v1/types.go b/types/v1/types.go
@@ -2054,7 +2054,7 @@ type ChangeNvmeHostMaxNumSysPortsParam struct {
 
 // NvmeHostParam defines struct for creating an NVMe host
 type NvmeHostParam struct {
-	Name           string    `json:"name"`
+	Name           string    `json:"name,omitempty"`
 	Nqn            string    `json:"nqn"`
 	MaxNumPaths    IntString `json:"maxNumPaths,omitempty"`
 	MaxNumSysPorts IntString `json:"maxNumSysPorts,omitempty"`