Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests #452

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Update tests #452

merged 1 commit into from
Oct 21, 2024

Conversation

scaronni
Copy link
Collaborator

@scaronni scaronni commented Oct 21, 2024

  • Drop Debian 11 (EOL).
  • Drop Ubuntu 23.10 (EOL).
  • Add Fedora 41.
  • Add Ubuntu 24.10.
  • Switch runs-on to Ubuntu 24.04.
  • Drop Gentoo; takes 30 minutes just to start the tests. Also, I don't quite get the Gentoo+DKMS combo, you rebuild the kernel, so along with that you rebuild the modules anyway.

@amilonenv amilonenv merged commit 848e874 into master Oct 21, 2024
54 checks passed
@scaronni scaronni deleted the tests branch October 21, 2024 13:10
@Nowa-Ammerlaan
Copy link
Contributor

Nowa-Ammerlaan commented Oct 21, 2024

  • Also, I don't quite get the Gentoo+DKMS combo, you rebuild the kernel, so along with that you rebuild the modules anyway.

What do you mean?? Gentoo is no different then any other distro in this regard (you know we also distribute a prebuilt kernel right?), out-of-tree kernel modules always need rebuilding on kernel updates. And not every module is packaged in the repository, that is where dkms comes in. I use it on my system to manage kernel modules that are only distributed in rpm/deb form. And I package dkms in our repository because I know others use it as well.

Frankly I am annoyed that you just drop this without even CC'ing me about it and that I have to find out when there is a new release and I can't find the results for the Gentoo tests. This test suite does not really run locally very well (it requires quite extensive write permissions) so I have been relying on the docker tests here to ensure that it works for us.

Please revert this, if there is a problem with the Gentoo tests then I will fix it (as I have in the past). Or fix the tests properly so they can actually run in an unprivileged environment and then I can get them to automatically run from inside the package manager.

@scaronni
Copy link
Collaborator Author

Frankly I am annoyed that you just drop this without even CC'ing me about it and that I have to find out when there is a new release and I can't find the results for the Gentoo tests. This test suite does not really run locally very well (it requires quite extensive write permissions) so I have been relying on the docker tests here to ensure that it works for us.

First of all, don't expect me to contact you because I don't even know who you are.

I can ask you the same question, why didn't you fix the bug that has been opened for quite some time and fixed the gentoo tests that failed for months (mostly due to the readelf output)?

Please revert this, if there is a problem with the Gentoo tests then I will fix it (as I have in the past). Or fix the tests properly so they can actually run in an unprivileged environment and then I can get them to automatically run from inside the package manager.

I'm not reverting anything, since you feel so entitled don't expect me to fix the tests for you. If you make a merge request that fixes both (test length and proper test output parsing) I'll be happy to merge.

@Nowa-Ammerlaan
Copy link
Contributor

Nowa-Ammerlaan commented Oct 22, 2024

I can ask you the same question, why didn't you fix the bug that has been opened for quite some time and fixed the gentoo tests that failed for months (mostly due to the readelf output)?

I would have, had you taken the small effort of looking through the git log to find out who got these tests running for Gentoo in the first place, and CC'ed me.....

I maintain several Gentoo testing scripts and such for various upstreams, I don't keep track of every single upstream issue as I am not an upstream maintainer, I just maintain the tests for Gentoo. You cannot expect me to just magically find out about some problem. You're going to have to communicate.

First of all, don't expect me to contact you because I don't even know who you are.

You don't have to know me, you have to look at the git log, that's what the git log is for. When something is broken and you don't feel like fixing it yourself, you find the original author. It's common sense. Immediately removing stuff as you do here is frankly disrespectful.

If you make a merge request that fixes both

I will, but I am going to need some assurance that it won't be removed without notice again, otherwise I am wasting my time.

@Nowa-Ammerlaan
Copy link
Contributor

Nowa-Ammerlaan commented Oct 23, 2024

If you make a merge request that fixes both (test length and proper test output parsing) I'll be happy to merge.

PR is open here: #454

Note that the complaint about the missing .comment section was a real issue that needed fixing, not some quirk to be handled in test output parsing. I adjusted the code here to properly handle this case without making unneeded noise (after all, the .comment section is optional). And the next iteration of the prebuilt Gentoo kernel will exclude vmlinux from stripping by default, meaning it should then again have a .comment section. This I think makes sense considering the purpose of this file, no need to have users who want to use it go through the extra manual step of disabling stripping.

Also added several optimizations for speed, tests now complete successfully after ~4 minutes.

@scaronni
Copy link
Collaborator Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants