-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests #452
Update tests #452
Conversation
What do you mean?? Gentoo is no different then any other distro in this regard (you know we also distribute a prebuilt kernel right?), out-of-tree kernel modules always need rebuilding on kernel updates. And not every module is packaged in the repository, that is where dkms comes in. I use it on my system to manage kernel modules that are only distributed in rpm/deb form. And I package dkms in our repository because I know others use it as well. Frankly I am annoyed that you just drop this without even CC'ing me about it and that I have to find out when there is a new release and I can't find the results for the Gentoo tests. This test suite does not really run locally very well (it requires quite extensive write permissions) so I have been relying on the docker tests here to ensure that it works for us. Please revert this, if there is a problem with the Gentoo tests then I will fix it (as I have in the past). Or fix the tests properly so they can actually run in an unprivileged environment and then I can get them to automatically run from inside the package manager. |
First of all, don't expect me to contact you because I don't even know who you are. I can ask you the same question, why didn't you fix the bug that has been opened for quite some time and fixed the gentoo tests that failed for months (mostly due to the readelf output)?
I'm not reverting anything, since you feel so entitled don't expect me to fix the tests for you. If you make a merge request that fixes both (test length and proper test output parsing) I'll be happy to merge. |
I would have, had you taken the small effort of looking through the git log to find out who got these tests running for Gentoo in the first place, and CC'ed me..... I maintain several Gentoo testing scripts and such for various upstreams, I don't keep track of every single upstream issue as I am not an upstream maintainer, I just maintain the tests for Gentoo. You cannot expect me to just magically find out about some problem. You're going to have to communicate.
You don't have to know me, you have to look at the git log, that's what the git log is for. When something is broken and you don't feel like fixing it yourself, you find the original author. It's common sense. Immediately removing stuff as you do here is frankly disrespectful.
I will, but I am going to need some assurance that it won't be removed without notice again, otherwise I am wasting my time. |
PR is open here: #454 Note that the complaint about the missing Also added several optimizations for speed, tests now complete successfully after ~4 minutes. |
Awesome, thank you! |
runs-on
to Ubuntu 24.04.