Move local to one var per line and init on seperate line
#435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase? I'll take a look just after. |
jcpunk
force-pushed
the
local_two_lines
branch
from
54e347f
to
9725adf
Compare
|
rebased |
|
@jcpunk tests do not run correctly. Please make sure nothing is broken and if the output has changed, please update the tests accordingly. |
This should resolve inconsistent results from shellcheck checks SC2178/SC2128
jcpunk
force-pushed
the
local_two_lines
branch
from
9725adf
to
a50b595
Compare
|
Sorry about that, I forgot to copy my changed code into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve inconsistent results from shellcheck checks SC2178/SC2128
The tests pass for me locally, but extra careful eyes would be nice.
In theory this gets us closer to consistent coding practices. I also renamed the variable
$mvto$modvwhere I saw it as typos there may lead to confusion with themvcommand.