Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion: Add value completion for more arguments #377

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

hyperupcall
Copy link
Contributor

This improves completion by:

  • Properly completing directory names and path names for more flags. Basic completion for -a was also implemented (defaulting to current architecture)
  • Restructure -@\(c|-spec|-archive|-config\) to something that works and is simpler. Now, even extglob does not need to be enabled for the new completion to work

@evelikov
Copy link
Collaborator

Amazing, thank you.

If you feel like adding zsh completion that would be very welcome. You can use the existing /usr/share/zsh/functions/Completion/Linux/_dkms as a base. Sending a message (email) to the zsh devs with a link to the PR would be perfect.

Thanks o/

@evelikov evelikov merged commit 11da62a into dell:master Dec 11, 2023
23 checks passed
@hyperupcall
Copy link
Contributor Author

Sounds good, I will get to it if I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants