Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depmod cleanup #374

Merged
merged 1 commit into from
Feb 8, 2024
Merged

depmod cleanup #374

merged 1 commit into from
Feb 8, 2024

Conversation

anbe42
Copy link
Contributor

@anbe42 anbe42 commented Dec 6, 2023

there are more hardcoded /lib/modules elsewhere, I haven't touch them

@anbe42 anbe42 marked this pull request as draft December 6, 2023 18:40
@anbe42 anbe42 mentioned this pull request Dec 6, 2023
Merged
evelikov
evelikov reviewed Dec 7, 2023
View reviewed changes
dkms.in Show resolved Hide resolved
@anbe42 anbe42 marked this pull request as ready for review January 11, 2024 10:58
@evelikov
Copy link
Collaborator

I need to think a bit more about the modules.dep checking ... IIRC there were some corner-cases where it might backfire.

The install_tree part is spot on, thank you. Fwiw I'm inclined to do a sweep soon (tm) adding a please-use-usr-lib-modules toggle, similar to the latest kmod release. Thus distros (Arch at least) don't manually patch the location.

@anbe42
do not run depmod if modules.dep does not yet exist
d624fe2 
i.e. only linux headers but no corresponding linux image is installed
evelikov
evelikov approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@evelikov evelikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I cannot see any problems with this, my gut feeling is keeps nagging me.

Nevertheless, let's land this - no point in delaying it any further.

Thanks for your help and sorry for the delay o/

@evelikov evelikov merged commit 797fbab into dell:master Feb 8, 2024
24 checks passed
@anbe42 anbe42 deleted the depmod branch March 25, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evelikov evelikov evelikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anbe42 @evelikov