Powermax operator support wizard #754

boyamurthy · 2023-08-17T09:29:25Z

Adding operator support for Powermax in installation wizard

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#885

Checklist:

Have you run a grammar and spell checks against your submission?
Have you tested the changes locally?
Have you tested whether the hyperlinks are working properly?
Did you add the examples wherever applicable?
Have you added high-resolution images?

github-actions · 2023-08-18T08:53:06Z

Test Results

  1 files   3 suites 1s ⏱️
72 tests 72 ✔️ 0 💤 0 ❌
73 runs 73 ✔️ 0 💤 0 ❌

Results for commit 5b6b019.

♻️ This comment has been updated with latest results.

niranjan-n1 · 2023-08-18T09:40:45Z

content/docs/deployment/csminstallationwizard/src/static/js/ui-functions.js

 			document.getElementById("driver-namespace").value = CONSTANTS_PARAM.POWERMAX_NAMESPACE;
+			if (installationType === 'operator') {


Suggested change

if (installationType === 'operator') {

if (installationType === CONSTANTS_PARAM.OPERATOR) {

niranjan-n1 · 2023-08-18T09:44:13Z

content/docs/deployment/csminstallationwizard/src/index.html

+		  <div class="row mb-4 iscsichap">
+                    <div class="col-sm-12">
+                      <input class="form-check-input" type="checkbox" id="iscsichap" value="" >
+                      <label for="iscsichap" class="form-check-label ms-2 text-dark" data-bs-toggle="tooltip" data-bs-placement="right" title="Enable/Disable ISCSI CHAPfeature">Iscsichap</label>


Suggested change

<label for="iscsichap" class="form-check-label ms-2 text-dark" data-bs-toggle="tooltip" data-bs-placement="right" title="Enable/Disable ISCSI CHAPfeature">Iscsichap</label>

<label for="iscsichap" class="form-check-label ms-2 text-dark" data-bs-toggle="tooltip" data-bs-placement="right" title="Enable/Disable ISCSI CHAPfeature">iSCSI CHAP</label>

niranjan-n1 · 2023-08-18T09:47:28Z

content/docs/deployment/csminstallationwizard/src/static/js/generate-yaml.js

@@ -147,8 +164,11 @@ function createYamlString(yamlTpl, yamlTplValues, driverParam, CONSTANTS_PARAM)
 	yamlTpl = yamlTpl.replaceAll("$POWERMAX_STORAGE_ARRAY_ENDPOINT_URL", yamlTplValues.storageArrayEndpointUrl);
 	yamlTpl = yamlTpl.replaceAll("$POWERMAX_STORAGE_ARRAY_BACKUP_ENDPOINT_URL", yamlTplValues.storageArrayBackupEndpointUrl);
 	yamlTpl = yamlTpl.replaceAll("$POWERMAX_MANAGEMENT_SERVERS_ENDPOINT_URL", yamlTplValues.storageArrayEndpointUrl);
+	yamlTpl = yamlTpl.replaceAll("$POWERMAX_MANAGE_ARRAY_ID", yamlTplValues.manageArrayId);
+	yamlTpl = yamlTpl.replaceAll("$POWERMAX_MANAGEE_ARRAY_ENDPOINT_URL", yamlTplValues.manageArrayEndpointUrl);


There is a typo in POWERMAX_MANAGEE_ARRAY_ENDPOINT_URL

niranjan-n1 · 2023-08-18T09:48:28Z

content/docs/deployment/csminstallationwizard/src/static/js/tests/generate-yaml.test.js

+            <input type="checkbox" id="iscsichap">
+            <input type="checkbox" id="observability-operator">
+            <input type="checkbox" id="observability-operator-metrics">
+            <input type="checkbox" id="vobservability-operator-topology">


There is a typo in the id "vobservability-operator-topology

niranjan-n1 · 2023-08-18T09:49:01Z

content/docs/deployment/csminstallationwizard/src/static/js/tests/generate-yaml.test.js

+            <input type="checkbox" id="iscsichap">
+            <input type="checkbox" id="observability-operator">
+            <input type="checkbox" id="observability-operator-metrics">
+            <input type="checkbox" id="vobservability-operator-topology">


There is a typo in the id "vobservability-operator-topology

niranjan-n1 · 2023-08-18T09:51:23Z

...ent/docs/deployment/csminstallationwizard/src/templates/operator/csm-powermax-1.7.0.template

+        # Default value: None
+        # Example: https://0.0.0.1:8443
+        - name: X_CSI_POWERMAX_ENDPOINT
+          value: $POWERMAX_MANAGEE_ARRAY_ENDPOINT_URL


There is a typo in the id $POWERMAX_MANAGEE_ARRAY_ENDPOINT_URL

content/docs/deployment/csminstallationwizard/src/index.html

niranjan-n1

Few comments and also Github actions are failing

niranjan-n1

LGTM

samihan-dell · 2023-08-18T10:26:13Z

...ent/docs/deployment/csminstallationwizard/src/templates/operator/csm-powermax-1.8.0.template

+        # Default value: None
+        # Example: https://0.0.0.1:8443
+        - name: X_CSI_POWERMAX_ENDPOINT
+          value: $POWERMAX_MANAGEE_ARRAY_ENDPOINT_URL


Typo same as mentioned above

samihan-dell · 2023-08-18T10:38:21Z

content/docs/deployment/csminstallationwizard/src/index.html

@@ -109,11 +109,50 @@
                    </div>
                  </div>

+		  <div class="row mb-4 observability-operator">


Please align the indentation for multiple div tags from line no. 112 to 145

samihan-dell · 2023-08-18T10:41:18Z

content/docs/deployment/csminstallationwizard/src/index.html

@@ -341,6 +380,26 @@
                    </div>
                  </div>

+		  <div class="managedArrays mb-4">


Please align the indentation for multiple div tags from line no. 383 to 458

* Adding RHEL 9.0 support for Powermax (#707) * Powerstore-Centralized-helm-Changes (#708) * Updated replication install doc for centralized helm charts (#711) * Release notes template (#714) * Using common helm charts for installation (#713) * Adding operator support for powerstore in wizard (#710) * add SCT to installation wizard pmax (#715) * Configurable Volume Attributes (#712) * PowerMax storage capacity Tracking documentation (#717) * Update powermax.md Added documentation for StorageCapacityTracking feature * Update powermax.md Added the StorageCapacityTracking * Update _index.md Made the StorageCapacityTracking to True * Update powermax.md Did changes related to SCT * Update powermax.md Added the supporting document for SCT * Update powermax.md Added row related to SCT * Update powermax.md Added document for SCT * Update powermax.md Added doc support for SCT * Update powermax.md Added doc support to PowerMax SCT * Update powermax.md Added doc support for SCT * Update powermax.md * Update powermax.md Added supporting feature for PowerMax driver * Update powermax.md Resolved the conflict * Update powermax.md Added supporting doc * Update powermax.md Modified the file * Update powermax.md Added Storage Capacity Tracking feature for Powermax * Update powermax.md --------- Co-authored-by: Yamunadevi N Shanmugam <[email protected]> * Health monitor enable steps (#722) * Update CODEOWNERS (#725) * Obs rep ocp (#724) * OpenShift 4.13 support for PowerMax (#709) * Cert Manager should display tooltip about the pre-requisite. (#721) * update resiliency support for ocp 4.13 (#727) * Doc updates for removing replication init container (#729) * add powerscale 9.5 support (#731) * Adding Operator Support for PowerScale in wizard (#733) * Automate cert-manager install with observability (#737) * Update observability.md to reflect automated cert-manager install * formatting * Update observability.md * Update observability.md * add link to cert-manager docs * Added example of running volumeHealthMetric suite (#734) * Adding the same example in /v1 i.e. for older release * Updated Google Anthos support for PowerMax (#740) * Powerflex-Centralized-helm-Changes (#742) * Updated v2.8.0 changes (#744) * Updated the resiliency module for Powerstore operator support in Installation Wizard UI (#745) * Update ocp version to 4.13: csi-powerflex (#741) * update ocp version to 4.13 * updated release notes with ocp4.13 support * added known issues * Documentation changes related to volume limit feature PowerMax (#749) * Update powermax.md Added changes related to Volume limits for PowerMax * Update powermax.md Added changes related to PowerMax volume limits feature * Update powermax.md Added changes related to Volume limit feature to PowerMax * Update powermax.md Added changes related to volume limit feature for PowerMax * Update powermax.md Added changes related to volume limit feature for PowerMax * Powerstore-Openshift-version-Changes (#747) * Updated PowerScale supported version for replication and observability (#750) * add prereq to install (#751) * Added docs for SCT feature Unity XT (#752) * Added example of few suites (#746) * Volume limit support in CSI Powerflex Driver (#748) * volume limit support in CSI Powerflex Driver * Incorporate review comments * Add support for kubernetes 1.28.0 - Observability and Replication (#756) Added Support for 1.28 for observability * PowerScale 9.5.0.4 support (#758) * PowerScale module operator support in Installation wizard (#757) * Adding k8 28 support for Powermax (#759) * Powermax operator support wizard (#754) * Update sdc to 3.6.1 (#762) * update sdc to 3.6.1 * updated release notes * Add offline bundle support in csm-operator (#760) * powerflex: support added for NFS (#763) * Added Support for k8s 1.28 in PowerStore (#767) * Helm changes unity v2.8.0 driver (#766) * Updated v2.8.0 driver version * Updated v2.8.0 driver version * Addressing the review comments on helm install * file replication (#769) * Added docs for SCT feature Powerflex (#761) * add sct changes to csm installation wizard. * powerflex storage capacity docs changes. --------- Co-authored-by: Ashley_Joy <[email protected]> * Csm installation wizard doc update (#771) * updated installation wizard doc changes * updated installation wizard doc changes * updated installation wizard doc changes * updated installation wizard doc changes * Updated UI for module support in powerscale (#765) * Updated UI for module support in powerscale * fix authorization issue * Updated support matrix (#768) Removed a troubleshooting point as we are adding support of RO pvc * Updating powermax templates (#773) * Powerstore OpenShift 4.13 known issues (#774) * Adding known issues related to Openshift 4.13 for CSI Powerstore * Update powerstore.md * Replication installation wizard (#775) * Testing release-notes tool (#778) Co-authored-by: csmbot <[email protected]> * Add deprecation notice to dell-csi-operator (#780) * Volume limits support in CSI Powerstore * add isDefault to samples (#785) * PowerStore: Volume limits support in Installation Wizard (#781) * volume limits support in installation wizard for powerstore * indentation fix * updated csm-version check * updated comparator Co-authored-by: Niranjan N <[email protected]> * increased width of max-volumes-per-node field --------- Co-authored-by: Niranjan N <[email protected]> * Config file update (#783) * NFS documentation updated (#786) * CSI Powerstore 2.8.0 documentation changes * Removed arrayConnectivityConnectionLossThreshold from podmon-node (#790) * Helm changes and Operator upgrade changes (#795) * Update offline install to include step for driver install (#794) * uncomment resiliency args (#797) * Unity installation changes for central helm (#789) * Updated the unity helm installation changes in document * Updated the unity helm installation changes in document * Addressed review comment * Addressed review comment on gut hub ulr update * CSM Installation Wizard:Disable Operator option for Powerflex and Unity (#784) * disabled operator support for powerflex & unity, added operator prerequiste note * minor change * fixed linter issues * fixed minor bug * fixed linter issue * fixed linter issue * fixed linter issue * Added COSI documentation (#779) * docs(cosi): added COSI documentation Signed-off-by: shanduur-dell <[email protected]> * fix(review/1): applied suggestions Signed-off-by: shanduur-dell <[email protected]> * feat: added defaults for Bucket provisioning Signed-off-by: shanduur-dell <[email protected]> * fix: command for helm install Signed-off-by: shanduur-dell <[email protected]> * fix(review/2): clarified obtaining values Signed-off-by: shanduur-dell <[email protected]> * fix(review/3): one more how-to clarification Signed-off-by: shanduur-dell <[email protected]> --------- Signed-off-by: shanduur-dell <[email protected]> * Documentation updates for CSI Unity (#791) * CSI Unity docs update * volume limit for unity in csm installation wizard * Removed please * Removed please * Removed please * Removed the known issue that is fixed * Replication Yaml creation enhancements (#804) * CSM Installation Wizard: Updated release notes (#799) * updated release notes * updated release notes * updated release notes * updated release notes * updated release notes * addressed review comment * added CSM installation wizard release notes link in common release notes * updated release notes * add max volume limit param in powerscale (#806) * Powerscale Upgrade (#807) * Powerscale Upgrade * Powerscale Upgrade * Powerscale Upgrade * Documentation updates for CSI Powerflex (#805) * updated powerflex docs * removed special chars * reverted orchestrator version bump up in csi-operator * adressed review comments * adressed review comments * updated example file name * addressed review comments * corrected n-2 version in csm-operator * fixed intendation (#810) * update dellctl images docs for CSM 1.8 (#812) * updated authorization and resiliency docs for release 1.8 (#800) * updated authorization and resiliency docs for release 1.8 * fixed support matrix for CSM components * Fixed Auth RPM and karavictl deprecation notes to refer to CSM 2.0 * fix: helm inconsistency (#816) * Observability updates for 1.8 release (#808) * Replication 1.6.0 updates for CSM 1.8.0 (#817) * Installation Wizard: PowerFlex new keys added (#809) * PowerFlex features added * Update known issue on Volume limits for Unity, PowerScale and Powerflex (#814) * update known issue * added vol limit known issue in powerscale * added vol limit known issue in powerscale * Updating volume limits known issue in Powerstore (#815) * Updated CSI-PowerScale Release notes and documentation (#821) * PowerMax documentation changes-release1.8 (#802) * Adding new changes for Powermax (#824) * csi-powerflex: NFS documentation updated (#822) * NFS parameters updated * updated resiliency version (#825) * remove-incorrect-section (#718) * Update csm-powermax-1.8.0.template (#829) * Bumped csi-volumegroup-snapshotter version (#828) * Bumped csi-volumegroup-snapshotter version * fixed CRDs * bump up version --------- Co-authored-by: JacobGros <[email protected]> * remove incorrect line (#770) * remove incorrect line * Update powerflex.md * Replication/Observability 1.6 updates for Installation Wizard (#830) * Update release-notes for release-v1.8.0 (#832) * Update known issue powermax (#833) * Rebase Main with Release 1.8.0 branch. * Removing 1.7.1 Comment from Index Page * Removing the 1.7.1 Placeholder Content from the Top Banner. * Helm charts version update (#835) * helm-charts version update * helm-charts version update * Removing powerpath known issue (#838) * Remove 1.28 support for 1.8 (#837) * update docs. (#839) * Rephrase the CSM Wizard steps (#787) * Rephrase the CSM Wizard steps * Address comments on the phrasing --------- Signed-off-by: shanduur-dell <[email protected]> Co-authored-by: boyamurthy <[email protected]> Co-authored-by: sakshi-garg1 <[email protected]> Co-authored-by: Santhosh Lakshmanan <[email protected]> Co-authored-by: Adarsh Kumar Yadav <[email protected]> Co-authored-by: chaganti-rajitha <[email protected]> Co-authored-by: Yamunadevi N Shanmugam <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: tssushma <[email protected]> Co-authored-by: Nitesh-Rewatkar <[email protected]> Co-authored-by: gallacher <[email protected]> Co-authored-by: AnandatDell <[email protected]> Co-authored-by: Luna Xu <[email protected]> Co-authored-by: shaynafinocchiaro <[email protected]> Co-authored-by: Chiman Jain <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> Co-authored-by: karthikk92 <[email protected]> Co-authored-by: ashleyvjoy <[email protected]> Co-authored-by: Rajendra Indukuri <[email protected]> Co-authored-by: panigs7 <[email protected]> Co-authored-by: rensyct <[email protected]> Co-authored-by: Rajshree Khare <[email protected]> Co-authored-by: VamsiSiddu-7 <[email protected]> Co-authored-by: Ashley_Joy <[email protected]> Co-authored-by: Niranjan N <[email protected]> Co-authored-by: shefali-malhotra <[email protected]> Co-authored-by: alankar-verma <[email protected]> Co-authored-by: CSM Bot <[email protected]> Co-authored-by: csmbot <[email protected]> Co-authored-by: Konduri Satya Narayana <[email protected]> Co-authored-by: Aaron Tye <[email protected]> Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: HarishH-DELL <[email protected]> Co-authored-by: Mateusz Urbanek <[email protected]> Co-authored-by: KerryKovacevic <[email protected]> Co-authored-by: Don Khan <[email protected]> Co-authored-by: JacobGros <[email protected]> Co-authored-by: sharmilarama <[email protected]> Co-authored-by: coulof <[email protected]>

boyamurthy and others added 9 commits August 8, 2023 14:21

Adding operator support for Powermax

8dea7f9

Adding observability support

50b8ee7

updating tests

26497ae

Updating changes

8b7873e

adding constants

383f575

updated unit tests and fixed replication in wizard

8fc188e

fixing unit-test

f4613e1

Fixing unit tests

879e95d

hide snapshot

5ff526f

boyamurthy requested review from bharathsreekanth, chimanjain, Deepak-Ghivari, gallacher, mgandharva, mjsdell, prablr79, rajendraindukuri, rajkumar-palani, rsedlock1958, shanmydell and sharont58 as code owners August 17, 2023 09:29

sharont58 previously approved these changes Aug 17, 2023

View reviewed changes

boyamurthy dismissed sharont58’s stale review via f3fa7a7 August 18, 2023 08:52

Fixing validations

e7447bf

boyamurthy force-pushed the Powermax_operator_support_wizard branch from f3fa7a7 to e7447bf Compare August 18, 2023 09:21

niranjan-n1 reviewed Aug 18, 2023

View reviewed changes

content/docs/deployment/csminstallationwizard/src/index.html Show resolved Hide resolved

niranjan-n1 requested changes Aug 18, 2023

View reviewed changes

Fixed review comments

4f84b5a

boyamurthy force-pushed the Powermax_operator_support_wizard branch from f61ad1f to 4f84b5a Compare August 21, 2023 04:51

Fixing linting errors

b4c9f3b

boyamurthy force-pushed the Powermax_operator_support_wizard branch from 72b9687 to b4c9f3b Compare August 21, 2023 05:36

fixing linting issues

484561d

boyamurthy force-pushed the Powermax_operator_support_wizard branch from 3dc2e9e to 484561d Compare August 21, 2023 06:20

linting issue

6b0b218

boyamurthy force-pushed the Powermax_operator_support_wizard branch from f558e64 to 6b0b218 Compare August 21, 2023 06:36

Merge branch 'release-1.8.0' into Powermax_operator_support_wizard

5b6b019

niranjan-n1 self-requested a review August 21, 2023 06:45

niranjan-n1 approved these changes Aug 21, 2023

View reviewed changes

shanmydell approved these changes Aug 21, 2023

View reviewed changes

samihan-dell approved these changes Aug 21, 2023

View reviewed changes

shanmydell merged commit 791583f into release-1.8.0 Aug 21, 2023
3 checks passed

shanmydell deleted the Powermax_operator_support_wizard branch August 21, 2023 08:57

khareRajshree pushed a commit that referenced this pull request Aug 21, 2023

Powermax operator support wizard (#754)

bec58d8

khareRajshree pushed a commit that referenced this pull request Aug 21, 2023

Powermax operator support wizard (#754)

e058ffb

khareRajshree pushed a commit that referenced this pull request Aug 21, 2023

Powermax operator support wizard (#754)

38866ac

khareRajshree pushed a commit that referenced this pull request Aug 21, 2023

Powermax operator support wizard (#754)

393314a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Powermax operator support wizard #754

Powermax operator support wizard #754

boyamurthy commented Aug 17, 2023

github-actions bot commented Aug 18, 2023 •

edited

Loading

niranjan-n1 Aug 18, 2023

boyamurthy Aug 21, 2023

niranjan-n1 Aug 18, 2023

boyamurthy Aug 21, 2023

niranjan-n1 Aug 18, 2023

boyamurthy Aug 21, 2023

niranjan-n1 Aug 18, 2023

boyamurthy Aug 21, 2023

niranjan-n1 Aug 18, 2023

boyamurthy Aug 21, 2023

niranjan-n1 Aug 18, 2023

boyamurthy Aug 21, 2023

niranjan-n1 left a comment

niranjan-n1 left a comment

samihan-dell Aug 18, 2023

samihan-dell Aug 18, 2023

samihan-dell Aug 18, 2023

		document.getElementById("driver-namespace").value = CONSTANTS_PARAM.POWERMAX_NAMESPACE;
		if (installationType === 'operator') {

	if (installationType === 'operator') {
	if (installationType === CONSTANTS_PARAM.OPERATOR) {

	<label for="iscsichap" class="form-check-label ms-2 text-dark" data-bs-toggle="tooltip" data-bs-placement="right" title="Enable/Disable ISCSI CHAPfeature">Iscsichap</label>
	<label for="iscsichap" class="form-check-label ms-2 text-dark" data-bs-toggle="tooltip" data-bs-placement="right" title="Enable/Disable ISCSI CHAPfeature">iSCSI CHAP</label>

Powermax operator support wizard #754

Powermax operator support wizard #754

Conversation

boyamurthy commented Aug 17, 2023

GitHub Issues

Checklist:

github-actions bot commented Aug 18, 2023 • edited Loading

Test Results

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niranjan-n1 left a comment

Choose a reason for hiding this comment

niranjan-n1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 18, 2023 •

edited

Loading