-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-1018] Refine Storage Group Feature #1031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CraneShiEMC
changed the title
Refine Storage Group Feature
[ISSUE-1018] Refine Storage Group Feature
Jul 1, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1031 +/- ##
==========================================
- Coverage 72.92% 72.72% -0.20%
==========================================
Files 62 63 +1
Lines 8266 8796 +530
==========================================
+ Hits 6028 6397 +369
- Misses 1980 2111 +131
- Partials 258 288 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Shi, Crane <[email protected]>
CraneShiEMC
force-pushed
the
feature-refine-storage-group
branch
from
July 2, 2023 06:07
91816f6
to
61a170a
Compare
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
…oup and its existing sg label takes no effect Signed-off-by: Shi, Crane <[email protected]>
CraneShiEMC
force-pushed
the
feature-refine-storage-group
branch
from
July 3, 2023 15:01
e4ad183
to
decc3b6
Compare
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
This reverts commit 06607e7. Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
CraneShiEMC
force-pushed
the
feature-refine-storage-group
branch
2 times, most recently
from
July 10, 2023 13:19
a710249
to
c769eb1
Compare
Signed-off-by: Shi, Crane <[email protected]>
CraneShiEMC
force-pushed
the
feature-refine-storage-group
branch
from
July 10, 2023 15:26
0f669b3
to
ee44769
Compare
Signed-off-by: Shi, Crane <[email protected]>
…beling support Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
libzhang
approved these changes
Jul 25, 2023
yanxiucai
approved these changes
Jul 25, 2023
aiqiEMC
approved these changes
Jul 26, 2023
yimingwangdell
approved these changes
Jul 26, 2023
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
…hFields Signed-off-by: Shi, Crane <[email protected]>
…s uuid Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Shi, Crane <[email protected]>
CraneShiEMC
added a commit
that referenced
this pull request
Jul 30, 2023
* add StorageGroupStatus Signed-off-by: Shi, Crane <[email protected]> * support StorageGroupStatus in current workflows Signed-off-by: Shi, Crane <[email protected]> * refine log Signed-off-by: Shi, Crane <[email protected]> * refine error handling Signed-off-by: Shi, Crane <[email protected]> * trigger storage group resync if applicable in drive removal Signed-off-by: Shi, Crane <[email protected]> * A drive whose Usage is REMOVED will not be selected in any storage group and its existing sg label takes no effect Signed-off-by: Shi, Crane <[email protected]> * sg feature will not apply to drive physically removed Signed-off-by: Shi, Crane <[email protected]> * handle the drive removal case of drive with manual sg label Signed-off-by: Shi, Crane <[email protected]> * fix go lint error Signed-off-by: Shi, Crane <[email protected]> * add UT case for drive-removal-triggered sg sync Signed-off-by: Shi, Crane <[email protected]> * improve UT coverage Signed-off-by: Shi, Crane <[email protected]> * refine sg annotation for drive removal Signed-off-by: Shi, Crane <[email protected]> * handle case of invalid sg for drive removal Signed-off-by: Shi, Crane <[email protected]> * also exclude removing sg for trigger sg resync in drive removal Signed-off-by: Shi, Crane <[email protected]> * refine sg removal status handling Signed-off-by: Shi, Crane <[email protected]> * Revert "refine error handling" This reverts commit 06607e7. Signed-off-by: Shi, Crane <[email protected]> * refine log and some code logic Signed-off-by: Shi, Crane <[email protected]> * try to add immutability validation rule to storagegroup spec Signed-off-by: Shi, Crane <[email protected]> * upgrade controller-gen version to v0.9.2 Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT initial Signed-off-by: Shi, Crane <[email protected]> * Revert "add storagegroupcontroller UT initial" This reverts commit 1ea8660. Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * fix Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * refactor and add UT of storagegroupcontroller Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * fix storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * refine the logic of sg deletion Signed-off-by: Shi, Crane <[email protected]> * refine Signed-off-by: Shi, Crane <[email protected]> * fix bug Signed-off-by: Shi, Crane <[email protected]> * fix go-lint err Signed-off-by: Shi, Crane <[email protected]> * fix go-lint error Signed-off-by: Shi, Crane <[email protected]> * add drive IsClean support, decrease k8s api call, remove manual sg labeling support Signed-off-by: Shi, Crane <[email protected]> * fix Signed-off-by: Shi, Crane <[email protected]> * fix Signed-off-by: Shi, Crane <[email protected]> * fix UT Signed-off-by: Shi, Crane <[email protected]> * refine corner case handling Signed-off-by: Shi, Crane <[email protected]> * fix Signed-off-by: Shi, Crane <[email protected]> * refine and add UT to storagegroupcontroller Signed-off-by: Shi, Crane <[email protected]> * refine storagegroupcontroller and add UT Signed-off-by: Shi, Crane <[email protected]> * make controller svc's k8scache also sync sg and lvg objs' Signed-off-by: Shi, Crane <[email protected]> * use k8s cache, re-support sg label manual change and refine in sg ctrl Signed-off-by: Shi, Crane <[email protected]> * fix lint err Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * storagegroup controller will not reconcile on drive delete event Signed-off-by: Shi, Crane <[email protected]> * not support Health, Status, Usage and IsClean as DriveSelector's MatchFields Signed-off-by: Shi, Crane <[email protected]> * in storagegroupcontroller's reconcile, only sync drive when reqName is uuid Signed-off-by: Shi, Crane <[email protected]> * refine the logic to avoid nil pointer error Signed-off-by: Shi, Crane <[email protected]> * revert the usage of k8scache Signed-off-by: Shi, Crane <[email protected]> * add custom storage group proposal draft Signed-off-by: Shi, Crane <[email protected]> * refine custom storage group proposal Signed-off-by: Shi, Crane <[email protected]> --------- Signed-off-by: CraneShiEMC <[email protected]>
CraneShiEMC
added a commit
that referenced
this pull request
Jul 31, 2023
* [ISSUE-1040] fix pip3 install PyYAML failed. (#1041) Signed-off-by: yimingwangdell <[email protected]> * [ISSUE-1018] Refine Storage Group Feature (#1031) * add StorageGroupStatus Signed-off-by: Shi, Crane <[email protected]> * support StorageGroupStatus in current workflows Signed-off-by: Shi, Crane <[email protected]> * refine log Signed-off-by: Shi, Crane <[email protected]> * refine error handling Signed-off-by: Shi, Crane <[email protected]> * trigger storage group resync if applicable in drive removal Signed-off-by: Shi, Crane <[email protected]> * A drive whose Usage is REMOVED will not be selected in any storage group and its existing sg label takes no effect Signed-off-by: Shi, Crane <[email protected]> * sg feature will not apply to drive physically removed Signed-off-by: Shi, Crane <[email protected]> * handle the drive removal case of drive with manual sg label Signed-off-by: Shi, Crane <[email protected]> * fix go lint error Signed-off-by: Shi, Crane <[email protected]> * add UT case for drive-removal-triggered sg sync Signed-off-by: Shi, Crane <[email protected]> * improve UT coverage Signed-off-by: Shi, Crane <[email protected]> * refine sg annotation for drive removal Signed-off-by: Shi, Crane <[email protected]> * handle case of invalid sg for drive removal Signed-off-by: Shi, Crane <[email protected]> * also exclude removing sg for trigger sg resync in drive removal Signed-off-by: Shi, Crane <[email protected]> * refine sg removal status handling Signed-off-by: Shi, Crane <[email protected]> * Revert "refine error handling" This reverts commit 06607e7. Signed-off-by: Shi, Crane <[email protected]> * refine log and some code logic Signed-off-by: Shi, Crane <[email protected]> * try to add immutability validation rule to storagegroup spec Signed-off-by: Shi, Crane <[email protected]> * upgrade controller-gen version to v0.9.2 Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT initial Signed-off-by: Shi, Crane <[email protected]> * Revert "add storagegroupcontroller UT initial" This reverts commit 1ea8660. Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * fix Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * refactor and add UT of storagegroupcontroller Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * fix storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * refine the logic of sg deletion Signed-off-by: Shi, Crane <[email protected]> * refine Signed-off-by: Shi, Crane <[email protected]> * fix bug Signed-off-by: Shi, Crane <[email protected]> * fix go-lint err Signed-off-by: Shi, Crane <[email protected]> * fix go-lint error Signed-off-by: Shi, Crane <[email protected]> * add drive IsClean support, decrease k8s api call, remove manual sg labeling support Signed-off-by: Shi, Crane <[email protected]> * fix Signed-off-by: Shi, Crane <[email protected]> * fix Signed-off-by: Shi, Crane <[email protected]> * fix UT Signed-off-by: Shi, Crane <[email protected]> * refine corner case handling Signed-off-by: Shi, Crane <[email protected]> * fix Signed-off-by: Shi, Crane <[email protected]> * refine and add UT to storagegroupcontroller Signed-off-by: Shi, Crane <[email protected]> * refine storagegroupcontroller and add UT Signed-off-by: Shi, Crane <[email protected]> * make controller svc's k8scache also sync sg and lvg objs' Signed-off-by: Shi, Crane <[email protected]> * use k8s cache, re-support sg label manual change and refine in sg ctrl Signed-off-by: Shi, Crane <[email protected]> * fix lint err Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <[email protected]> * storagegroup controller will not reconcile on drive delete event Signed-off-by: Shi, Crane <[email protected]> * not support Health, Status, Usage and IsClean as DriveSelector's MatchFields Signed-off-by: Shi, Crane <[email protected]> * in storagegroupcontroller's reconcile, only sync drive when reqName is uuid Signed-off-by: Shi, Crane <[email protected]> * refine the logic to avoid nil pointer error Signed-off-by: Shi, Crane <[email protected]> * revert the usage of k8scache Signed-off-by: Shi, Crane <[email protected]> * add custom storage group proposal draft Signed-off-by: Shi, Crane <[email protected]> * refine custom storage group proposal Signed-off-by: Shi, Crane <[email protected]> --------- Signed-off-by: CraneShiEMC <[email protected]> --------- Signed-off-by: yimingwangdell <[email protected]> Signed-off-by: CraneShiEMC <[email protected]> Co-authored-by: yimingwangdell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #1018
Refine Storage Group Feature:
PR checklist
Testing
Manual test passed.
Custom CI passed: https://asd-ecs-jenkins.isus.emc.com/job/csi-custom-ci/1559/
Custom Acceptance Passed: https://asd-ecs-jenkins.isus.emc.com/job/csi-custom-acceptance-tar_b_ona/36/