Refactorings by Jasper Denkers #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit f26233e Merge: 5f4e620 7d4fd64 Author: Jasper Denkers <[email protected]> Date: Sun Apr 10 20:13:26 2016 +0200 Merge pull request #15 from jasperdenkers/4-csplsp-particlemesh #4 Encapsulate responsibilities of ParticleMesh to prevent OCP/LSP violation commit 5f4e620 Merge: ad3b6de 7f4aca1 Author: Jasper Denkers <[email protected]> Date: Sun Apr 10 20:13:14 2016 +0200 Merge pull request #14 from jasperdenkers/3-srp-camera #3 Re-engineer SRP violations in Camera commit ad3b6de Merge: 1b3dcad df6a6fc Author: Jasper Denkers <[email protected]> Date: Sun Apr 10 20:13:02 2016 +0200 Merge pull request #13 from jasperdenkers/2-srp-spatial #2 Re-engineer SRP violations in Spatial commit 1b3dcad Merge: 281a572 85e280a Author: Jasper Denkers <[email protected]> Date: Sun Apr 10 20:12:47 2016 +0200 Merge pull request #12 from jasperdenkers/7-dry-violation-fix #7 Re-engineer DRY violations in math package commit 7d4fd64 Author: Jasper Denkers <[email protected]> Date: Sat Apr 9 13:04:14 2016 +0200 #4 Encapsulate responsibilities of ParticleMesh to prevent OCP/LSP violation commit 7f4aca1 Author: Jasper Denkers <[email protected]> Date: Fri Apr 8 15:36:35 2016 +0200 #3 Renaming Frustum.Intersect to follow inheritance structure Using Intellij IDEA’s refactor tool this was easy commit b8fc762 Author: Jasper Denkers <[email protected]> Date: Fri Apr 8 15:29:57 2016 +0200 #3 Do similar refactoring for the Camera's frustum: put in separate class This one was pretty big commit 4b70613 Author: Jasper Denkers <[email protected]> Date: Fri Apr 8 14:23:32 2016 +0200 #3 Remove unnecessary methods (would brake external interface) Before this commit, the interface of Camera wasn’t changed commit 91f1ba7 Author: Jasper Denkers <[email protected]> Date: Fri Apr 8 14:15:15 2016 +0200 #3 Preserve actions on change of viewport commit f4b0198 Author: Jasper Denkers <[email protected]> Date: Fri Apr 8 13:47:09 2016 +0200 #3 Group Camera viewport properties in separate class This keeps the Camera viewpoint intact commit df6a6fc Author: Jasper Denkers <[email protected]> Date: Fri Apr 8 11:23:45 2016 +0200 #2 Move Spatial transformation methods into SpatialTransformer commit 85e280a Author: Jasper Denkers <[email protected]> Date: Thu Apr 7 22:11:26 2016 +0200 #7 Remove duplicated Quaternion.slerp code commit 0795865 Author: Jasper Denkers <[email protected]> Date: Thu Apr 7 22:02:14 2016 +0200 #7 Refactor Quaternion to fix DRY violation Add’s a helper method for setting 3D values in a Matrix4f by providing a Matrix3f commit 36bcffa Author: Jasper Denkers <[email protected]> Date: Thu Apr 7 21:58:31 2016 +0200 #7 Add helper for converting 3D matrix to 4D, by adding zeros for fourth dimension commit 836cb2f Author: Jasper Denkers <[email protected]> Date: Thu Apr 7 21:37:24 2016 +0200 #7 Test 3D/4D quaternion -> matrix conversion commit ff88d7b Author: Jasper Denkers <[email protected]> Date: Thu Apr 7 21:26:33 2016 +0200 #7 Add delta based equality to matrices Diff kinda got messed up due to incomplete previous commit commit de91e1c Author: Jasper Denkers <[email protected]> Date: Thu Apr 7 21:17:17 2016 +0200 #7 Simplify existing Matrix equality methods commit 6d9cbb9 Author: Jasper Denkers <[email protected]> Date: Thu Apr 7 21:14:15 2016 +0200 #7 Add helper math class for float equality checks commit f83a5f3 Author: Jasper Denkers <[email protected]> Date: Thu Apr 7 20:53:02 2016 +0200 #7 First tests for Quaternion commit 281a572 Merge: 8726484 d8f5569 Author: Jasper Denkers <[email protected]> Date: Wed Mar 23 15:01:11 2016 +0100 Merge pull request #11 from jasperdenkers/9-junit-assertions Use JUnit assertions commit d8f5569 Author: Jasper Denkers <[email protected]> Date: Wed Mar 23 14:59:49 2016 +0100 #9 Remove Java assertions from jme3-core commit 8d853e5 Author: Jasper Denkers <[email protected]> Date: Wed Mar 23 14:57:29 2016 +0100 Refactor LightSortTest to prevent DRY violation in test commit 96b4eb7 Author: Jasper Denkers <[email protected]> Date: Wed Mar 23 14:47:48 2016 +0100 #9 Use JUnit's assert methods instead of Java asserts commit 8726484 Merge: 10947e8 391717b Author: Jasper Denkers <[email protected]> Date: Wed Mar 23 14:10:36 2016 +0100 Merge pull request #10 from jasperdenkers/1-sbt-builds Use SBT for building the jme3-core module commit 391717b Author: Jasper Denkers <[email protected]> Date: Wed Mar 23 11:37:41 2016 +0100 #1 Testing in forked JVM with assertions enabled commit ad0877a Author: Jasper Denkers <[email protected]> Date: Wed Mar 23 10:56:58 2016 +0100 #1 Compiling with SBT commit 1add1f9 Author: Jasper Denkers <[email protected]> Date: Wed Mar 23 10:56:32 2016 +0100 #1 Merge plugins and tools packages in main jme3-core package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of several components within jME's core module, with the focus on S.O.L.I.D. violation fixes. Additionally, SBT is introduced as a build tool.
Issue/PR references are based on a private copy of the repository. These references are messed up within /delftsre/jmonkeyengine.