Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

products: add registry entries for Neon and String #123

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

Djelibeybi
Copy link
Collaborator

They were added to the official JSON file yesterday.

@Djelibeybi Djelibeybi requested a review from delfick November 25, 2023 06:49
@Djelibeybi
Copy link
Collaborator Author

Djelibeybi commented Nov 25, 2023

I haven't done anything about the fact that the number of zones returned by GetExtendedColorZones and I assume required by SetExtendedColorZones has jumped quite a bit.

A single String is 108 zones (9 zones per "bulb" and 12 "bulbs" per string) and you can join up to three Strings so I guess the zone count could go as high as 324 for the String.

My Neon is only arriving next week, but they can't be extended (AFAIK) so they'll probably come in below that amount.

@Djelibeybi Djelibeybi force-pushed the add-neon-and-string branch 2 times, most recently from 63265c5 to 86ce716 Compare November 25, 2023 22:15
Copy link
Owner

@delfick delfick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@delfick delfick merged commit 504093f into delfick:main Nov 25, 2023
13 checks passed
@Djelibeybi Djelibeybi deleted the add-neon-and-string branch November 26, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants