feat(rootfs/deploy.py): remove image after it's pushed #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,3 +67,6 @@ def log_output(stream, decode): | |||
| print("pushing to registry") | |||
| stream = client.push(registry+'/'+imageName, tag=imageTag, stream=True, insecure_registry=True) | |||
| log_output(stream, False) | |||
| print("deleting image") | |||
| stream = client.remote_image(image=registry+'/'+imageName, force=True, noproune=False) | |||
There was a problem hiding this comment.
remote_image? Should this be remove_image?
Also noprune rather than noproune
There was a problem hiding this comment.
Always happy to see more international contributions to the project 🇫🇷
There was a problem hiding this comment.
haha, nope - it's supposed to be remove_image. fixed in 28db3dd
|
Waiting to merge until e2e tests go green |
|
@smothiki should this stay open? needs rebase and tests fail |
|
Let's push this in for this release. If the image pull is successful, we dont need a copy of the image on the host |
Fixes deis#29 fix(rootfs/deploy.py): use named params fix(deploy.py): replace remote_image (typo) with remove_image fix(deploy.py): fix another typo in noprune
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29