-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Port evaluation harness from haystack-experimental
#8595
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 12200323610Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Can we add the DocumentNDCGEvaluator to the supported metrics as we port it? |
|
adding @anakin87 since he's working on removing pandas/DataFrames dependencies |
@davidsbatista thanks for the ping. In general, my idea would be to have |
@anakin87, I don't oppose removing But if we want to keep it optional, some functionality like |
Proposed Changes:
Port the evaluation harness from the experimental package.
How did you test it?
Unit tests
Notes for the reviewer
The source feature branch doesn't originate from a fork, so you can directly push to branch if need be.
We should ensure that we have the usage docs for the harness and its related classes ready so that both the code and the docs are merged at the same time, i.e., during the same release.
@dfokina Feel free to review the docstrings as well.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.