Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pt): support CPU parallel training with PT #4224

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

iProzd
Copy link
Collaborator

@iProzd iProzd commented Oct 16, 2024

Fix #4132.

Summary by CodeRabbit

  • New Features

    • Enhanced backend selection for distributed training, allowing for flexible use of NCCL or Gloo based on availability.
  • Bug Fixes

    • Corrected indentation for improved code clarity.

@iProzd iProzd linked an issue Oct 16, 2024 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented Oct 16, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request focus on the get_trainer function in deepmd/pt/entrypoints/main.py, enhancing the initialization of the distributed process group by implementing a flexible backend selection process. The new logic checks for the availability of both NCCL and Gloo backends, initializing the process group with a combined backend string. The local_rank variable's indentation has been corrected, and the control flow for invoking the prepare_trainer_input_single function has been clarified. The overall structure of the train function remains unchanged.

Changes

File Change Summary
deepmd/pt/entrypoints/main.py Modified get_trainer function for flexible backend selection (NCCL or Gloo); corrected indentation of local_rank assignment; clarified control flow for invoking prepare_trainer_input_single.

Assessment against linked issues

Objective Addressed Explanation
Support CPU parallel training with PT (#4132)

Possibly related PRs

  • feat(pt): support DeepEval.eval_descriptor #4214: The changes in the DeepEval class may relate to the overall training and evaluation process, which could be impacted by the modifications in the get_trainer function regarding backend initialization for distributed training.
  • fix(pt): make PT training step idx consistent with TF #4221: The adjustments to the training step index in the Trainer class could be relevant as they may affect how training progress is logged and displayed, which is part of the broader training framework that the get_trainer function is involved in.

Suggested reviewers

  • wanghan-iapcm

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 0b0d943 and f9b43e8.

📒 Files selected for processing (1)
  • deepmd/pt/entrypoints/main.py (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • deepmd/pt/entrypoints/main.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 5050f61 and 0b0d943.

📒 Files selected for processing (1)
  • deepmd/pt/entrypoints/main.py (1 hunks)
🧰 Additional context used

deepmd/pt/entrypoints/main.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.54%. Comparing base (5050f61) to head (f9b43e8).
Report is 13 commits behind head on devel.

Files with missing lines Patch % Lines
deepmd/pt/entrypoints/main.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #4224      +/-   ##
==========================================
+ Coverage   83.52%   84.54%   +1.02%     
==========================================
  Files         542      537       -5     
  Lines       52544    51236    -1308     
  Branches     3043     3050       +7     
==========================================
- Hits        43888    43320     -568     
+ Misses       7709     6966     -743     
- Partials      947      950       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iProzd iProzd requested a review from njzjz October 23, 2024 04:48
@iProzd iProzd added this pull request to the merge queue Oct 23, 2024
Merged via the queue into deepmodeling:devel with commit a74d963 Oct 23, 2024
60 checks passed
@iProzd iProzd deleted the add_gloo_support branch October 23, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] support CPU parallel training with PT
3 participants