add aidl parcelables into aar #16
Conversation
0xera
force-pushed
the
aidl_parcelables
branch
from
d265b82
to
67d3a1b
Compare
| attribute(Usage.USAGE_ATTRIBUTE, objects.named(Usage::class.java, Usage.JAVA_RUNTIME)) | ||
| attribute(Usage.USAGE_ATTRIBUTE, objects.named(Usage::class.java, Usage.JAVA_API)) |
There was a problem hiding this comment.
The second call overwrites the first, which one do you want to use and why? See comments in source code just above
Looks like you used JAVA_API in artifactsOf() for AIDL, so this could be left as JAVA_RUNTIME
There was a problem hiding this comment.
sorry, forgot to remove first line. i have tried to left only JAVA_RUNTIME but in that case i cannot access to aidl files.
0xera
force-pushed
the
aidl_parcelables
branch
from
67d3a1b
to
f0cd6ec
Compare
0xera
changed the title
0xera
force-pushed
the
aidl_parcelables
branch
from
f0cd6ec
to
2eabbb8
Compare
|
I approved before seeing there was a new commit 😄 I guess you're still working on this. I spent quite some time earlier to investigate why we need a special combination of API and RUNTIME, but I could not figure it out. In my understanding when you set the usage attribute in artifactsOf(), you kind of override the usage attribute given to the configuration. I'll check with your changes |
0xera
force-pushed
the
aidl_parcelables
branch
from
2eabbb8
to
3ade5f6
Compare
| attribute(Usage.USAGE_ATTRIBUTE, objects.named(Usage::class.java, Usage.JAVA_RUNTIME)) | ||
| } | ||
| } | ||
| val configurationApi = configurations.create(nameOf(greasifiedName, "api")) { |
There was a problem hiding this comment.
aidl parcelable files from project dependencies can be accessed only via greaseApi configuration
0xera
changed the title
|
I dont have any other idea, so i have just added api configuration for special cases when we need include aidl parcelables from project dependencies in fat aat |
|
@natario1 what do you think about this solution? |
|
I'll take a look tomorrow! |
Closes #15