Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add least-squares minimization capabiliy for Czjzek and Extended Czjzek #285

Merged
merged 28 commits into from
Mar 30, 2024

Conversation

mgiammar
Copy link
Collaborator

No description provided.

@mgiammar mgiammar changed the title Add least-squares minimization capabiliy for Czjzek and Extended Czjzek [WIP] Add least-squares minimization capabiliy for Czjzek and Extended Czjzek Jul 10, 2023
@mgiammar mgiammar self-assigned this Jul 10, 2023
@mgiammar mgiammar added enhancement New feature or request documentation Documentation updates python Pull requests that update Python code labels Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Attention: Patch coverage is 80.69498% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 99.32%. Comparing base (47b4ccd) to head (545e4dd).
Report is 8 commits behind head on master.

Files Patch % Lines
src/mrsimulator/utils/spectral_fitting.py 56.94% 31 Missing ⚠️
src/mrsimulator/models/utils.py 56.25% 14 Missing ⚠️
src/mrsimulator/models/czjzek.py 93.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   98.70%   99.32%   +0.62%     
==========================================
  Files         119      120       +1     
  Lines        8080     8330     +250     
==========================================
+ Hits         7975     8274     +299     
+ Misses        105       56      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepanshs
Copy link
Owner

@mgiammar Any updates on this PR?

@mgiammar
Copy link
Collaborator Author

mgiammar commented Sep 18, 2023

@mgiammar Any updates on this PR?

@deepanshs No, no updates. We discussed building a SpinSystemDistribution object to encapsulate all the functions and necessary data to perform LS minimization for some dataset; I currently don't have the bandwidth to work on that feature. Otherwise, I have the necessary fitting functions implemented and workflow outlined in a gallery example.

@deepanshs deepanshs merged commit 1069e82 into deepanshs:master Mar 30, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation updates enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants