-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add several new layers to be able to support Resnet like architectures #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…there were a bug when processing images)
remove useless summary
…fle; modify pytest (warning only support 2D inputs, and single value kernel size)
franckma31
requested review from
cofri,
thib-s,
y-prudent,
mathieu-serrurier and
massena-t
December 2, 2024 17:45
thib-s
reviewed
Dec 4, 2024
thib-s
reviewed
Dec 4, 2024
thib-s
reviewed
Dec 4, 2024
thib-s
reviewed
Dec 4, 2024
thib-s
reviewed
Dec 4, 2024
thib-s
reviewed
Dec 4, 2024
thib-s
reviewed
Dec 4, 2024
thib-s
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments
Also, tests seem to break for some versions.
franckma31
force-pushed
the
feat/new_layers
branch
from
December 9, 2024 15:56
96e5249
to
16b0059
Compare
franckma31
added a commit
that referenced
this pull request
Dec 10, 2024
franckma31
added a commit
that referenced
this pull request
Dec 10, 2024
franckma31
force-pushed
the
feat/new_layers
branch
from
December 10, 2024 09:15
f3f32bb
to
5f10dad
Compare
franckma31
added a commit
that referenced
this pull request
Dec 10, 2024
franckma31
force-pushed
the
feat/new_layers
branch
from
December 10, 2024 09:30
5f10dad
to
a0a81da
Compare
franckma31
force-pushed
the
feat/new_layers
branch
from
December 10, 2024 09:32
a0a81da
to
76a6e69
Compare
thib-s
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support and unit tests for replicate padding in convolution (unconstrained.py)
Add support and unit tests for LipResidual (residual.py)
Modify InvertibleDownSampling and InvertibleUpSampling to use Pixel(Un)Shuffle pytorch functions
Add support and unit tests for SpectralConv1d (conv.py)
Add support and unit tests for HouseHolder activation (activation.py)
Add support and unit tests for SpectralConv1d (conv.py)
Add support and unit tests for BatchCentering and LayerCentering (normalization.py)
Add support and unit tests for SpectralConvTranspose2d (conv.py)
Add support and unit tests for ScaledGlobalL2NormPool2d (pooling.py)
Update update groupsort and groupsort2 activation to be consistent with deellip (actication.py)
Add a Warning in notebooks to support vanilla_export after loading weights, to solve the issue [Bug]: -
vanilla_export
leads to loss of accuracy #17