-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytest unit tests, new losses support, and normalization enhancement #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in [0,1], and min_margin/2.0
cofri
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many valuable changes! Nice and big work
massena-t
reviewed
Oct 29, 2024
franckma31
force-pushed
the
feat/update_normalizers
branch
from
November 7, 2024 16:41
7592b90
to
9658d27
Compare
franckma31
force-pushed
the
feat/update_normalizers
branch
from
November 13, 2024 09:23
47dcf7c
to
9c2d4a1
Compare
cofri
approved these changes
Nov 27, 2024
cofri
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Torchlip library has undergone several updates to align more closely with the functionalities provided by deel-lip (TensorFlow). Here are the key changes:
Transition to pytest for unit tests, sharing a common test suite with deel-lip. The utils_framework.py file has been introduced to facilitate adaptation of names and parameters.
Enhancements in the available loss functions:
Normalizers (Spectral and Bjorck): Updated with a stopping criterion based on an epsilon value (eps) rather than a fixed number of iterations
Bjorck parenthesis trick added (reduce computational complexity)