-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPV #20
Open
OrfeasLitos
wants to merge
543
commits into
decrypto-org:master
Choose a base branch
from
OrfeasLitos:spv-extension
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SPV #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add class NodeClient 2. Add class Network 3. Add property network to FullNode and SPVNode 4. Expand class WalletDB a. Add open() b. Add connect() c. Add create() 5. Add node with property NodeClient to bcoin module
Using Address.fromHash() without a network argument returns a main net address, which is not always desired. Thus pubKeyToEntity() now takes the type of network as an argument and passes it to Address.fromHash(). All cases where this function is used are expanded with the new input. Additionally, the DirectTrust class is expanded with the network property for use in pubKeyToEntity() calls.
* Change Hash type from String to Buffer * Use new bcrypto library * Use getCoinView() instead of getSpentView()
OrfeasLitos
force-pushed
the
spv-extension
branch
from
January 24, 2021 10:44
e7cc4fc
to
a1eecc3
Compare
Please enter the commit message for your changes. Lines starting
OrfeasLitos
force-pushed
the
spv-extension
branch
from
January 24, 2021 10:54
a1eecc3
to
8d6afe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.