[0.6] btc: update btcwallet for rescan panic fix #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
changed the title
JoeGruffins
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rescanning a native btcwallet on v0.6 is difficult to accomplish without a panic crash on account of recently fixed upstream bug. We applied this fix to master in #2396, one month ago, but we were cautious about advancing btcwallet and neutrino revisions this much.
However, given the trouble this causes in practice, particularly with poor internet or unreliable peers, I'm offering this fix on
release-v0.6.p.s. I'm not sure how close we are to cutting to 0.7/1.0, but I don't think it's close enough to wait on this.