Support libraries in decomp.me #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's one mypy error that I just can't figure out for the life of me. If someone can find a fix, I'd be grateful. Otherwise, this feature is ready for review. |
roblabla
force-pushed
the
libraries
branch
2 times, most recently
from
713fa61
to
5c09987
Compare
mkst
reviewed
Sep 27, 2023
I think the library flag(s) that get appended should always start with a space
|
Nice catch, I added a space, and also moved the libraries to be within |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR introduces libraries in decomp.me. This is a new section under "Options" that allow adding libraries to the scratch, which allows the user to
#includethe headers provided by that lib.Fixes #842
Example:
This is ready for review.