Moving window normalized fee #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
isaacJChen
commented
Nov 18, 2020
isaacJChen
commented
- Calculate normalized fee
- Version protocol parameters
isaacJChen
requested review from
csuwildcat,
OR13,
tplooker and
troyronda
as code owners
| @@ -21,17 +22,26 @@ export default class NormalizedFeeCalculator implements IFeeCalculator { | |||
| } | |||
|
|
|||
| public async getNormalizedFee (block: number): Promise<number> { | |||
| // DB call optimization | |||
| // https://github.com/decentralized-identity/sidetree/issues/936 | |||
There was a problem hiding this comment.
Nit: standard patterns is to append TODO to enable searching and automated tooling (such as extension in VSC).
Suggested change
| // https://github.com/decentralized-identity/sidetree/issues/936 | |
| // TODO: https://github.com/decentralized-identity/sidetree/issues/936 |
| * Normalized fee sohuld always be populated in core layer when core makes call to transactions endpoint. | ||
| * It may not be populated in blockchain service. This allows flexibility for the value to be computed on the spot or stored. | ||
| * To remove potentially dangerous behavior. Make a seperate model | ||
| * https://github.com/decentralized-identity/sidetree/issues/937 |
There was a problem hiding this comment.
Nit: add TODO for tooling/searching.
Suggested change
| * https://github.com/decentralized-identity/sidetree/issues/937 | |
| * TODO: https://github.com/decentralized-identity/sidetree/issues/937 |
| @@ -149,8 +149,8 @@ export default class BitcoinProcessor { | |||
| /** | |||
| * Initializes the Bitcoin processor | |||
| */ | |||
| public async initialize () { | |||
| await this.versionManager.initialize(this.blockMetadataStore); | |||
| public async initialize (versionModels: BitcoinVersionModel[]) { | |||
There was a problem hiding this comment.
I guess BitcoinProcessor was the example I was looking for for dependency injection, so I still want to make sure we have an agreed upon pattern. Let's discuss but won't block the PR on this.
| @@ -63,7 +65,7 @@ export default class JasmineSidetreeErrorValidator { | |||
| } | |||
|
|
|||
| if (!validated) { | |||
| fail(`Expected error '${expectedErrorCode}' did not occur.`); | |||
| fail(`Expected error '${expectedErrorCode}' did not occur. Instead got '${actualError.code}'`); | |||
thehenrytsai
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.