feat: Support Exotic rarity #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meelrossi
approved these changes
Apr 3, 2024
src/ports/orders/utils.ts
Outdated
| @@ -210,7 +210,7 @@ export const getOrdersQuery = ( | |||
|
|
|||
| export function fromOrderFragment( | |||
| fragment: OrderFragment, | |||
| network: Network, | |||
| network: Network.MATIC | Network.ETHEREUM, | |||
| fromItemFragment(fragment, network, chainId) | ||
| fromItemFragment( | ||
| fragment, | ||
| network as Network.ETHEREUM | Network.MATIC, |
There was a problem hiding this comment.
is this necessary? fromItemFragment is receiving AssetsNetwork too
There was a problem hiding this comment.
This network variable comes from the ItemFilters, which is still using the Rarity type. As changing it might impact multiple projects, I chose casting it here, but I made sure that we were getting one or the other when receiving the query parameters.
meelrossi
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the NFT server to support the exotic rarity.