Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/easy import #1051

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Feature/easy import #1051

wants to merge 4 commits into from

Conversation

nicoecheza
Copy link
Contributor

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Jan 16, 2025

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: d612eba
Status: ✅  Deploy successful!
Preview URL: https://5205dc5b.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feature-easy-import.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feature/easy-import/dcl-sdk-7.7.2-12837147067.commit-136b0ed.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feature/easy-import/dcl-sdk-commands-7.7.2-12837147067.commit-136b0ed.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feature/easy-import/@dcl/inspector/dcl-inspector-7.7.2-12837147067.commit-136b0ed.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feature/easy-import-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feature/easy-import

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 27.58621% with 147 lines in your changes missing coverage. Please review.

Project coverage is 62.77%. Comparing base (680459b) to head (d612eba).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...@dcl/inspector/src/components/ImportAsset/utils.ts 16.04% 136 Missing ⚠️
...spector/src/components/ImportAsset/Slider/types.ts 0.00% 5 Missing and 1 partial ⚠️
...@dcl/inspector/src/components/ImportAsset/types.ts 90.90% 3 Missing ⚠️
...s/@dcl/inspector/src/components/FileInput/types.ts 0.00% 1 Missing ⚠️
...spector/src/components/ImportAsset/Slider/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
- Coverage   64.03%   62.77%   -1.27%     
==========================================
  Files         579      594      +15     
  Lines       18049    19573    +1524     
  Branches     2288     2402     +114     
==========================================
+ Hits        11558    12286     +728     
- Misses       6082     6870     +788     
- Partials      409      417       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant